Code Monkey home page Code Monkey logo

Comments (35)

fgl27 avatar fgl27 commented on July 17, 2024 2

The day I release the next app version I'll open a new issue for this.

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024 1

@pi0ne3r @Xynetha I push all the changes, thanks for the help.

from smarttv-twitch.

Rossano95 avatar Rossano95 commented on July 17, 2024 1

I need to only a few more strings. For now it's pretty complete
it_IT.zip

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024 1

OK I see if I re-enable the function again tomorrow and test it. I let you know.

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024 1

That is no longer valid translation. I plan to update the app, so the strings have all changed.

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024 1

Everything general translation from Android will be reused...

Just some strings that are related to Samsung version that will be missing, but most people will not notice it when using the app.

from smarttv-twitch.

DerSani1988 avatar DerSani1988 commented on July 17, 2024

@fgl27 is it possible to test a translation? I tried to add in /app/language, edited the main.js and settings.js but the app doesn't start in the emulation, did I miss something?

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

You can install the app from the repository folder by, fork, clone, import the cloned folder as a file system to a new app, and install. you can make the changes on top of the en_US.js so it loads by default and you see, I deal with the settings changes later don't wonry.

If you don't use git just makes the download and install from here:
https://github.com/fgl27/smarttv-twitch/archive/master.zip

And do the same "changes on top of the en_US.js so it loads by default and you see"

Use the ladybug icon to install the app, in case the app doesn't open is because some line is wrong in the file and the log will warn about with line.

the emulator is the same process, but is better to do on the tv, the above link will not uninstall the released version of the app you already have installed will just install side by side.

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

here is a sample on how to fully add a language:
7b6f867#diff-1b40fc887130f4b9bfa361fe3f795211

but I do that no problem, just a sample. maybe you miss the index.html change or a line on the translation code is bad and cause the app to crash

from smarttv-twitch.

DerSani1988 avatar DerSani1988 commented on July 17, 2024

@fgl27 please find attached the German translation (de_DE) - Deutsch [DE]:

de_DE.zip

Kindly note some small changes are necessary on your side:

  1. Suggestion: This comma should be added to the other language files to provide more flexibility for upcoming translations an would look cleaner in German translation:
    _Channel_colon

  2. As above:
    _main

  3. Suggestion: Date variable for display day without "/":
    _date

  4. Another comma and the bottom menu should be resized:
    _player

  5. Dot needs to me removed (if it is not a lot of work)
    _playermanual

Something further: A few vars are not translated due to logical reason e.g. "Following" and some other vars couldn't be found in app so the context wasn't clear.

If I see something in the future I can improve (logics, typos) I'll let you know.

Cheers

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

I push yours translation you can finished if you wanna by downloading and installing the app from here:
https://github.com/fgl27/smarttv-twitch/archive/master.zip

and updating the de_DE.js and sharing it here (you can just drag the file here no need to zip btw)

Strings that you will not translate you don't make it "", you just "comment it out" like this
https://github.com/fgl27/smarttv-twitch/blob/master/app/languages/de_DE.js#L30

the word "for" doesn't translate to |, if it doesn't have a proper way to translatable try to explain to me why is that.

In relation to yours numbers...

"1. 2. and 5." you miss translate some things that is way looks odd's for you, now that the language is there you can change to english refresh the screen see how is in english go back change to German refresh again see what is missing to change and do it, or not leave as is but don't add empty strings

"3." yes a space there looks better

"4." I don't understand the resize, you mean removed?...I fix the visual glitches.

The string "Following" is there next to the heart on the bottom on the player and in the Agame section, but only shows if you add a user and is Following the streamer/game, I fix the odd looking layouts there so you can see it now, may there be more places that look odd if you find let me know, as on differents tvs things may look a little different.

thanks no rush.

from smarttv-twitch.

DerSani1988 avatar DerSani1988 commented on July 17, 2024

Sharing the .js file as an attachment was not possible.

Regarding 1 and 2:
I've removed the "for" value and replaced with "|" for better looking
Screenshot_6

Regarding 5:
I've translated the needed information compact and overseeable. Without changing the meaning.

Regarding 4:
I mean the visual issue caused by the length of the German words (i think this is what you mean with visual glitch)

I'll check your update soon and respond

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

I wanna to keep things familiar this is how the twitch player looks
Screenshot from 2019-05-04 09-46-13

that is way the "playing" and "for" words are there, don't worry if looks odd I fix later

Replace the file ext to txt or zip it with ever is easy, I didn't know they limited the file type

The "ago" I will remove.

from smarttv-twitch.

DerSani1988 avatar DerSani1988 commented on July 17, 2024

So it's your app and i respect your wishes. I've added the "playing" and "for" translation.

//STR_CONTROLS_MAIN_7 = "";
//STR_CONTROLS_MAIN_11 = "";
//STR_CONTROLS_PLAY_16 = "";
are not needed - as I mentioned before, the translation is not word by word. The meaning is still the same, only may reduced to the important things to prevent a confusing wall of text. (The last one did not work on any tested TV nor on simulation, and was removed)

//STR_STARTED = "";
Is grammatically wrong (if translated) and needs to be removed.
_started

The about section I wanted to keep original, so as many apps do, and it's easier for you to update. I commented out.

Hope above explanation will help you to understand why I do things this way, if you have any questions, please feel free to ask.

Please find attached the updated language file.
de_DE_v2.zip

If you have another updated version please let me know I'll check once again before rolling out in the main version.

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

Ok I move the missing translation to the bottom
https://github.com/fgl27/smarttv-twitch/blob/master/app/languages/de_DE.js#L216-L219

So you or anyone can update they in the future.

If something looks odd/misplaced on yours end let me know.

from smarttv-twitch.

DerSani1988 avatar DerSani1988 commented on July 17, 2024

I've reviewed the file and made two small changes here. I Think nothing else i can provide at this point. Will check next days spending time using the app.

Thank you @fgl27 for your development and providing this great app, I appreciate your work!

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

you welcome, thank you for the help I remove the "am" by mistake i will keep without the ":" makes sense with or without. Already merge everything.

from smarttv-twitch.

pi0ne3r avatar pi0ne3r commented on July 17, 2024

ru_Ru.zip
Added Russian language support, @fgl27 please proceed with it!

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

@pi0ne3r I will check and push it later I let you know so you can re-check after I do.

from smarttv-twitch.

Athenyx04 avatar Athenyx04 commented on July 17, 2024

Spanish translation added.

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

Ok I push it all later thanks.

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

@pi0ne3r can you find small similar translations? for:
STR_FEATURED = 'Featured';
STR_USER = "User ";

If possible share here I update the ru_RU for those.

I push the es and ru translation, @Xynetha @pi0ne3r let me know if anything doesn't look OK.

from smarttv-twitch.

pi0ne3r avatar pi0ne3r commented on July 17, 2024

@pi0ne3r can you find small similar translations? for:
STR_FEATURED = 'Featured';
STR_USER = "User ";

If possible share here I update the ru_RU for those.

Thanks @fgl27 , I attached edited translation with few replaces for more shortres words
ru_Ru.zip

from smarttv-twitch.

Rossano95 avatar Rossano95 commented on July 17, 2024

Hello, I have updated the traduction. It only needed a few strings.
it_IT.zip

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

Push it thanks.

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

I made a new app, and because of that remove all translations.

If anyone that did on the past a translation can do it again I will be thankful.

To test your new translation the simple way is to download the source

https://github.com/fgl27/smarttv-twitch/archive/master.zip

change the default language file

https://github.com/fgl27/smarttv-twitch/blob/master/app/languages/en_US.js

and Install the source as a new app and test, after all good share the file here and tell me from what language that is, if there is necessity to change the layout of the app, because some part of the app looks odd too small too big, let me know where so I can properly change fix it.

If anyone found a bug on the new app open a separated issue.

from smarttv-twitch.

Rossano95 avatar Rossano95 commented on July 17, 2024

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

@Rossano95

This is what I have change from the en_US.js

cfaf5ba

Is not all but was too many changes making the translation incompatible. I add most new strings on the bottom, and change and remove some old ones.

Maybe you can understand by reading the commit and update only what I have change, if not and you can translate just do it all.

from smarttv-twitch.

Rossano95 avatar Rossano95 commented on July 17, 2024

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

OK you don't need to do.

from smarttv-twitch.

Sam-arch99 avatar Sam-arch99 commented on July 17, 2024

Where can I change the language? I've installed the app via your tutorial and it's working great on my Q90R!! Much love <3

from smarttv-twitch.

fgl27 avatar fgl27 commented on July 17, 2024

Where can I change the language? I've installed the app via your tutorial and it's working great on my Q90R!! Much love <3

the app has 0 translations.

from smarttv-twitch.

Sam-arch99 avatar Sam-arch99 commented on July 17, 2024

the app has 0 translations.

Oh ok, I thought that people already helped with the translation progress (e.g. German) and you already implemented those translations in the app.

from smarttv-twitch.

Rossano95 avatar Rossano95 commented on July 17, 2024

I sended the italian translation. If you enable It I can check if it's ok.

from smarttv-twitch.

eze92 avatar eze92 commented on July 17, 2024

Just out of curiosity, is it possible to pass the translation that was made in the android version to this one? or will you have to re-translate from scratch?

from smarttv-twitch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.