SelectQuery isn't compatible with PromiseLike? about mammoth HOT 5 CLOSED

Yes. It would be nice for those queries to actually to call implements PromiseLike<..> so it's compatibility is actually enforced. Does this only happen for the select query or also delete/insert/update queries?

from mammoth.

Looks like it happens in all cases. I get "not assignable to type PromiseLike" errors on all these lines:

    acceptPromiseLike(db.select(db.foo.id).from(db.foo));
    acceptPromiseLike(db.select(db.foo.id).from(db.foo).where(db.foo.id.eq('1')));
    acceptPromiseLike(db.update(db.foo).set({id: '1'}));
    acceptPromiseLike(db.update(db.foo).set({id: '1'}).where(db.foo.id.eq('1')));
    acceptPromiseLike(db.deleteFrom(db.foo));
    acceptPromiseLike(db.insertInto(db.foo).values({id: '1'}));

from mammoth.

It looks like this is fixed already — or I cannot reproduce it. See https://codesandbox.io/s/ecstatic-archimedes-pnbsk?file=/src/index.ts.

In any case I'm closing this issue assuming it's fixed. Please let me know if you can create a reproducible sandbox.

from mammoth.

👍 Just checked in our own codebase and I can't repro anymore.

(Maybe Mammoth changed something or maybe TypeScript changed something?)

from mammoth.

Good to hear, thanks.

from mammoth.