Code Monkey home page Code Monkey logo

Comments (11)

williewillus avatar williewillus commented on August 24, 2024 2

I'm going to hot potato this one over to Forge. Botania is simply using the forge json ore dict ingredient format, so there's nothing really we can do to fix it. the real bug is forge creating empty entries from these ingredients.

from cathedral.

ferreusveritas avatar ferreusveritas commented on August 24, 2024 1

I added code to check if the ore list is empty.

from cathedral.

erindal avatar erindal commented on August 24, 2024

I interestingly did not have this issue with a test pack with just JEI, Chisel w/ prereqs, and this mod.

from cathedral.

ferreusveritas avatar ferreusveritas commented on August 24, 2024

That is interesting actually. I wonder why nihiltres is having a problem then.

from cathedral.

ferreusveritas avatar ferreusveritas commented on August 24, 2024

I'm unable to reproduce this problem. I ran the mod with only Cathedral, CTM, Chisel, and JEI and I can craft the Dwemer block with a gold ingot. You might want to double check and try again otherwise I'm afraid you'll need to find the origin of the problem yourself and report back with new information.

from cathedral.

nihiltres avatar nihiltres commented on August 24, 2024

Tracked it down to a minimal instance; it occurs if Botania and basically nothing else is installed. Here's the minimal instance modlist:

  • AutoRegLib (Botania dependency)
  • Baubles (Botania dependency)
  • Botania (Botania itself)
  • Cathedral (duh)
  • Chisel (Cathedral dependency)
  • CTM (I always leave this installed if using Chisel)
  • Just Enough Items (ease of testing)

If I disable Botania but leave its dependencies, then the problem doesn't occur.

I'll save you a little time and link to a search of the Botania repo for "brass". Not sure why that's there as Botania doesn't use brass as far as I know.

from cathedral.

erindal avatar erindal commented on August 24, 2024

So that...initializes an ore dict entry, making the mod think there's brass when there actually isn't?

from cathedral.

ferreusveritas avatar ferreusveritas commented on August 24, 2024

I don't think there's much I can do about this. Other mods expecting ingotBrass to work(which should be a reasonable expectation) would also be broken by Botania.

from cathedral.

williewillus avatar williewillus commented on August 24, 2024

Also, couldn't this mod check if ingotBrass has any real entries? (i.e. the list is nonempty)

from cathedral.

ferreusveritas avatar ferreusveritas commented on August 24, 2024

I can give it a shot if it will expedite getting this out of way.

from cathedral.

ashcorpdev avatar ashcorpdev commented on August 24, 2024

Any chance this fix will be uploaded soon?

As a temporary fix I just used a crafttweaker script to add the recipe back in, but it would be nicer if it worked out the box. No rush of course, just wondering if it'll be updated soon :)

from cathedral.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.