Comments (6)
Hi @fernandorpm and @arthurborgesdev ,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Students Handbook you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.
from book-a-teacher-api.
Hi @fernandorpm and @arthurborgesdev - as the only missing thing is a set of screenshots that is easy to be done, please do the following:
- add screenshots as requested :)
- request a re-review
- continue working on the project
I will re-review it in my morning as the requested changes are not blocking your progress 💪
from book-a-teacher-api.
Hi!
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
- please add a set of screenshots that will show all the cards on your board. This request will be approved once you do that :)
Optional suggestions
Every comment below is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- merge columns
Review in progress
andReviewer approved
into one columnIn review
, you will have the information about the approval in the PR and in the email notification. Double-checking it in the kanban board is not necessary and it produces an extra step for the reviewer. - there is one card that is an additional feature added by you #20. It is awesome and that feature makes perfect sense but please consider putting it in the bottom of the list to make sure that you implement the required features first
- please consider adding a prefix to the titles of your cards that will indicate the optional cards - this will help you to assess quickly how far you are with your progress before the final presentation
- those two cards seem to overlap as rails migrations will create the database structure: https://github.com/fernandorpm/book-a-teacher-api/issues/1 & #6
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Students Handbook you have a limited number of code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.
from book-a-teacher-api.
Hello @nidalaa !
All of the required and optional changes have been done!
We have also asked for a re-review, as you suggested.
Thanks for the feedback! 🚀
from book-a-teacher-api.
@fernandorpm I cannot see your re-review request - can you go to your Dashboard and submit it.
Without that I cannot approve this project:)
from book-a-teacher-api.
My bad! I thought that I was supposed to ask for the re-review (through the forms), the one that we ask for a second opinion.
Asked for another review! Thanks!
from book-a-teacher-api.
Related Issues (20)
- [1pt] Initialize Rails API
- [1pt] Initialize React Web App
- [1pt] Seed the Database
- [2pt] Create Models and Migration
- [8pt] Create Teacher API Routes
- Optional - [6pt] Create Booking API Routes
- Optional - [4pt] Create the API Documentation
- [2pt] Create a simple login page
- [4pt] Create Navigation Panel
- [6pt] Implement Redux Structure
- [3pt] Create Main Page
- [2pt] Create Teacher Details Page
- [3pt] Create Add Teacher Page
- Optional - [2pt] Create Delete Teacher Page
- Optional - [2pt] Create My Bookings Page
- Optional - [3pt] Create Make a Booking Page
- Optional - [2pt] Create Delete Booking Page
- [12pt] Styling the Application
- [4pt] Set up Rails Active Storage
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from book-a-teacher-api.