Spin compatibility: remove wasi-experimental-http about bartholomew HOT 10 CLOSED

Actually, I may have this wrong. I don't see Bartholomew using wasi-experimental-http directly, it is just in the Cargo.lock. Perhaps what is necessary is to bump the spin SDK version?

from bartholomew.

I just tested it and the SDK version is not causing it. It is a dependency handlebars-sprig which causes this. Downgrading that to v0.2.0 solves this.

v0.3.0 introduced the tweets and gists functions which rely on wasi_experimental_http. I am not sure what the approach towards this must be.

from bartholomew.

Thanks for checking this out, @karthik2804. Interesting... would we lose functionality if we go with the v0.2.0 downgrade?

from bartholomew.

i had been working on a branch to fix it. but don't have a fix for it right now. v0.3.0 was working fine with Bartholomew when we released it first. i am not too sure why it stopped working

downgrading to v0.2.0 will lose tweets/gists embedding functionality. we can downgrade until we can fix it?

from bartholomew.

It doesn't work because one of the latest commits to spin removed support for wasi-experimental-http (fermyon/spin#699) as mentioned in the OP. It will still work with Bartholomew when using spin built from a commit prior to that.

from bartholomew.

Yeah, we don't need to remove functionality — rather than using the bespoke wasi_experimental_http crate, it can use the Spin SDK directly, or import wasi_outbound_http from Spin.

from bartholomew.

I was able to get it working with spin sdk, but not able to publish new release as it needs a released version of spin-sdk.

Is that something we can do @radu-matei ?

I will spend more time on it tomorrow and will try to get a release pushed (worst case try to implement outbound http in handlebars sprig repo).

Thank you everyone for the inputs.

from bartholomew.

@rajatjindal can we not just switch from using a release of handlebars-sprig in Bartholomew to using a git as a source in the dependancy?

from bartholomew.

We can, i was just not sure of it will be acceptable.

If the team is ok with that, i am happy to open pr for it.

from bartholomew.

That definitely works, @rajatjindal!
Thank you!

from bartholomew.