Generated barrelfile incomplete about openapi-typescript-codegen HOT 17 CLOSED

I don't have the time to write some tests, could I leave that to you?

from openapi-typescript-codegen.

Hi Pieter, let me check, I'll add some additional test cases for these scenarios.

from openapi-typescript-codegen.

Great! I'm currently seeing if I can make a PR to fix this.

from openapi-typescript-codegen.

Weird thing is that if I look at your code, it seems valid to me, yet with even version 0.4.4 I see the behaviour is wrong.

from openapi-typescript-codegen.

@PieterVanEde Can you share you spec with me? Is that possible?

from openapi-typescript-codegen.

Or the better question: if you generate it with the default options, does everything look good then?

from openapi-typescript-codegen.

Yep, after fooling around a bit, I've found the following:

• if generated with default options, all looks fine.
• if generated with everything set to false, the barrel file is empty (correct)
• if generated with exportCore: true, exportModels: false, exportSchemas: false, exportServices: true, then only the core and models end up in the barrel (wrong)
• if generated with exportCore: true, exportModels: true, exportSchemas: false, exportServices: false, then I only get the core and services in the barrel (wrong)
• and like that I see more cases where the generate flags seem to have effect on the wrong section in the barrel file.

from openapi-typescript-codegen.

Ah maybe the parsing logic of the booleans are wrong somehow, are using the Node API or using it via command line / package json?

from openapi-typescript-codegen.

The parsing is indeed wrong, I've linked my local checkout of my fork inside my test project, and added this to the top of the index.hbs:

{{#if exportCore}} // pieter was here: exportCore true {{/if}} {{#if exportModels}} // pieter was here: exportModels true {{/if}} {{#if exportSchemas}} // pieter was here: exportSchemas true {{/if}} {{#if exportServices}} // pieter was here: exportServices true {{/if}}

Result for config exportCore: true, exportModels: false, exportSchemas: false, exportServices: true, is core and models

from openapi-typescript-codegen.

I'm using the typescript interface to call the library

from openapi-typescript-codegen.

Strangely enough, only the barrel file is wrong. The actual files that are output, are correct.

from openapi-typescript-codegen.

Error spotted, PR on its way

from openapi-typescript-codegen.

PR is created, hope you agree ;)

from openapi-typescript-codegen.

Cool, thanks for spotting this, stupid mistake, will push a new version to npm now

from openapi-typescript-codegen.

Pushed 0.4.5

from openapi-typescript-codegen.

I re-opend this as a reminder to add some test cases

from openapi-typescript-codegen.

Great! And well, there is a stupid mistake in a great library that I could use for free, so I don't see a problem ;)

from openapi-typescript-codegen.