Comments (3)
Issue is that since we do not associate any relationships between meshes in the objects, it gets problematic to distinguish between non-matching meshes and a sub-mesh parent mesh relation when one has no cells on a process for:
-
Have parent cells, no submesh cells
-
No parent cells, no submesh cells (no cells for either nonmatching grid).
-
Is easy to fix, 2, however, is challenging to fix without adding a flag to interpolate stating if we want to call non-matching interpolation (as this uses mpi communication).
from dolfinx.
Issue is that since we do not associate any relationships between meshes in the objects, it gets problematic to distinguish between non-matching meshes and a sub-mesh parent mesh relation when one has no cells on a process for:
- Have parent cells, no submesh cells
- No parent cells, no submesh cells (no cells for either nonmatching grid).
- Is easy to fix, 2, however, is challenging to fix without adding a flag to interpolate stating if we want to call non-matching interpolation (as this uses mpi communication).
The first problem seems to be that the code conflates None
and len(foo) == 0
, which breaks when a sub-mesh has no cells on a rank. This is a failure in logic.
The second is a design failure - one function doing too many different things. And it's not clear from the argument descriptions what is going on.
Unless there is an easy and good fix, the change should probably be wound back until it can done properly.
from dolfinx.
Working on a fix where a user that wants non-matching interpolation has to pass in an enum indicating this. Should not affect usage of normal interpolation
from dolfinx.
Related Issues (20)
- Test needed for dof permutations on prism and pyramid cells
- Read mixed topology mesh from file HOT 3
- Add mixed topology functionality to mesh partitioning HOT 1
- Write mixed topology mesh to file
- Generate Python type stubs using nanobind (v2)
- [BUG]: interpolation on CR space HOT 3
- [BUG]: #3215 introduced a regression: cannot have anymore `dx(1)` and `dx` in the same form
- [BUG]: Packing of codim-0 form not working for mixture of measures HOT 2
- Re-enable Windows build HOT 1
- [BUG]: cannot export several components of function with VTX HOT 7
- Allow `CoordinateElement` to be passed to built-in mesh generators
- Define concept of `FunctionSpace` for mixed topology
- using shared_ptr comparison for entity_maps keys
- Performance regression in collapsing blocked subspace HOT 11
- [BUG]: Visualization of one dimensional data with ParaView HOT 5
- [BUG]: Implicit use of previously created function space HOT 1
- [BUG]: Can't (easily) assemble a block vector without providing a left-hand side in Python HOT 2
- Parent cells not correct in refine_plaza HOT 2
- Access NewtonSolver residual from Python
- Enable macOS CI on PRs (PETSc-less)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dolfinx.