Code Monkey home page Code Monkey logo

Comments (3)

jorgensd avatar jorgensd commented on August 23, 2024

Issue is that since we do not associate any relationships between meshes in the objects, it gets problematic to distinguish between non-matching meshes and a sub-mesh parent mesh relation when one has no cells on a process for:

  1. Have parent cells, no submesh cells

  2. No parent cells, no submesh cells (no cells for either nonmatching grid).

  3. Is easy to fix, 2, however, is challenging to fix without adding a flag to interpolate stating if we want to call non-matching interpolation (as this uses mpi communication).

from dolfinx.

garth-wells avatar garth-wells commented on August 23, 2024

Issue is that since we do not associate any relationships between meshes in the objects, it gets problematic to distinguish between non-matching meshes and a sub-mesh parent mesh relation when one has no cells on a process for:

  1. Have parent cells, no submesh cells
  2. No parent cells, no submesh cells (no cells for either nonmatching grid).
  3. Is easy to fix, 2, however, is challenging to fix without adding a flag to interpolate stating if we want to call non-matching interpolation (as this uses mpi communication).

The first problem seems to be that the code conflates None and len(foo) == 0, which breaks when a sub-mesh has no cells on a rank. This is a failure in logic.

The second is a design failure - one function doing too many different things. And it's not clear from the argument descriptions what is going on.

Unless there is an easy and good fix, the change should probably be wound back until it can done properly.

from dolfinx.

jorgensd avatar jorgensd commented on August 23, 2024

Working on a fix where a user that wants non-matching interpolation has to pass in an enum indicating this. Should not affect usage of normal interpolation

from dolfinx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.