Code Monkey home page Code Monkey logo

Comments (8)

FelixHerrmann avatar FelixHerrmann commented on May 29, 2024

Can you show me one or more examples where it's failing? (Screenshot of the package root directory or url if it's public)
The filename and location are the key factors.

from swift-package-list.

notapplicableio avatar notapplicableio commented on May 29, 2024

I originally noticed it with a private package that wraps a third-party library. (This has a LICENSE.md.)

But, I think the same is happening with:

from swift-package-list.

FelixHerrmann avatar FelixHerrmann commented on May 29, 2024

Thanks, the British spelling is indeed not handled, the other ones should work from a first glance tho, will investigate that!

from swift-package-list.

notapplicableio avatar notapplicableio commented on May 29, 2024

Thanks, Felix. By the way, love this package. I selected it some time ago when it just supported JSON - which wasn't ideal, but I still liked it - but that you've added additional support is truly appreciated. :)

from swift-package-list.

FelixHerrmann avatar FelixHerrmann commented on May 29, 2024

Thanks for the kind words! And yes, this tool def. evolved compared to what it was at the beginning...

from swift-package-list.

FelixHerrmann avatar FelixHerrmann commented on May 29, 2024

I originally noticed it with a private package that wraps a third-party library. (This has a LICENSE.md.)

But, I think the same is happening with:

Ok I did some investigations, I added all of these to a demo project and the only one that fails for me is the British spelling one (which was expected because it's not handled). I will fix that but I cannot investigate the other ones from my side. The checked-out package repositories are located at ~/Library/Developer/Xcode/DerivedData/your-project/SourcePackages/checkouts if you want to take a look there, mine looks like this:
Screenshot 2023-08-03 at 16 29 17

The logic for the license find is located here:

return packageFiles.first { $0.deletingPathExtension().lastPathComponent.lowercased() == "license" }

from swift-package-list.

notapplicableio avatar notapplicableio commented on May 29, 2024

Thanks, your fix for "licence" works perfectly.

Through some instrumentation I have discovered that the content of "pins" in the Package.resolved file is not the same as the packages I have added. So, in the case above, Keychain is not appearing in there so never gets picked up by swift-package-list.

This is not really your problem anymore, but do you know why this file would be out of sync?

NVM: I'm using an xcworkspace! Now it all works! :)

from swift-package-list.

FelixHerrmann avatar FelixHerrmann commented on May 29, 2024

Thanks, your fix for "licence" works perfectly.

Awesome, will make a release then!

NVM: I'm using an xcworkspace! Now it all works! :)

Perfect, good to hear that! If I have to guess, you had an xcodeproj with SPM and converted that to a xcworkspace at some point. As soon as you have the workspace this will maintain the source of truth (Package.resolved) for your packages.

from swift-package-list.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.