Socket binding collision about node-ar-drone HOT 9 CLOSED

Good catch.
Usually you have to bind a udp socket to receive data on it, but it should not be this._port (since that's the one we're sending to, we can receive on any port).
Imho this should just be changed to this._socket.bind() without any argument.

from node-ar-drone.

@bkw SGTM. Have you tried it if it works?

I think I'll actually need to use the ar-drone lib on a drone myself fairly soon, so I'll probably check this out in a few days if nobody else does.

from node-ar-drone.

@felixge - I can confirm that removing the port bind doesn't mess anything up

from node-ar-drone.

@contra so nav data is still being received?

from node-ar-drone.

@felixge - Yep - everything is working as it should. I'm flying mine around right now and receiving the navdata state changes from #18

from node-ar-drone.

@contra alright, if you want to send a patch (that passes the test suite), go ahead, and I'll merge it right away!

from node-ar-drone.

The idiomatic way to receive on a UDP socket is to bind it (not necessarily to a specific port), so no other local processes can snatch it while you're using it. Maybe academic in our case but should not hurt either.
AFD (away from drone), but I'll make an extra check later.

from node-ar-drone.

vote to close, continued in #21

from node-ar-drone.

Fixed in master now - closing

from node-ar-drone.