Code Monkey home page Code Monkey logo

Comments (5)

orestesgaolin avatar orestesgaolin commented on August 24, 2024 3

Few remarks:

  1. Security - this feature allows for execution of arbitrary code on the user's machine. If implemented, we should clearly notify the user and ask for approval when running any script that is not maintained by us
  2. I see the resemblance to the git hooks and maybe hooks could be a more natural name for them? Then either pre-build or pre_build hooks would be present in the hooks directory
  3. There should be a way to skip and approve running the scripts in a headless mode e.g. --skip-script-approval and --skip-scripts or similar

from mason.

felangel avatar felangel commented on August 24, 2024

Thanks for the quick feedback @orestesgaolin! 🙏

  1. Security - this feature allows for execution of arbitrary code on the user's machine. If implemented, we should clearly notify the user and ask for approval when running any script that is not maintained by us

I was hesitant about this from a security standpoint as well but after thinking about it it's really not much different than installing a dart package from pub.dev and running it on your machine. I think we should expect that developers evaluate the bricks they choose to use and use discretion when it comes to what they install/run on their machine.

  1. I see the resemblance to the git hooks and maybe hooks could be a more natural name for them? Then either pre-build or pre_build hooks would be present in the hooks directory

I like that suggestion and I'm happy to rename to hooks and use pre_build instead of pre_gen 👍

  1. There should be a way to skip and approve running the scripts in a headless mode e.g. --skip-script-approval and --skip-scripts or similar

Yup, completely agree!

from mason.

cyrsis avatar cyrsis commented on August 24, 2024

Kind of off topic,

But I use mason to assemble basiclly from express , next, flutter,
db , even firestore + ansible

So load of bricks

The problem I ran into is those appending those scripts in

image

package.json

pubspec.yaml is a mess

Can we just do package.json inside of flutter project.

something like

"scripts": {
    "assmeble": "mason assemble ."
}

That just the end goal , it brings in all those line in info.plist , gradle,

from mason.

felangel avatar felangel commented on August 24, 2024

Kind of off topic,

But I use mason to assemble basiclly from express , next, flutter, db , even firestore + ansible

So load of bricks

The problem I ran into is those appending those scripts in

image

package.json

pubspec.yaml is a mess

Can we just do package.json inside of flutter project.

something like

"scripts": {
    "assmeble": "mason assemble ."
}

That just the end goal , it brings in all those line in info.plist , gradle,

You should be able to use something like derry to manage scripts in your pubspec.yaml similar to a package.json. Hope that helps 👍

from mason.

felangel avatar felangel commented on August 24, 2024

This is closed by #153 and is available in mason v0.0.1-dev.57 🎉

from mason.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.