Code Monkey home page Code Monkey logo

Comments (6)

fefit avatar fefit commented on August 15, 2024

@1984204066 Hi, thx for the issue, i don't know the original html you used in this case, so i used the following code and had a try.

let html = r#"
	<div id="content">
		<img data-src="img/1-png?wx_fmt=png" />
		<img data-src="img/2-jpg?wx_fmt=jpg" />
	</div>
"#;
let root = Vis::load(html).unwrap();
let mut content = root.find("#content");
fn get_images(content: &mut Elements, no: &str) {
	content.find("img").for_each(|idx, img| {
		if let Some(src) = img.get_attribute("data-src") {
			let src = src.to_string();
			let re = Regex::new("wx_fmt=([^&]*)").unwrap();
			if let Some(cap) = re.captures(&src) {
				if let Some(fmt) = cap.get(1) {
					let ext = fmt.as_str();
					let fname = format!("{no}-{idx}.{ext}");
					let new_img = format!("<img src='./img/{fname}' />");
					let mut new_img = Vis::load(&new_img).unwrap();
					Vis::dom(img).replace_with(&mut new_img);
				}
			}
		}
		true
	});
}
get_images(&mut content, "abc");
println!("{}", root.outer_html());

the above code will ouput:

<div id="content">
  <img src='./img/abc-0.png' />
  <img src='./img/abc-1.jpg' />
</div>

Here are some things should explain:

  1. the set_html method is set the element's inner_html, img is a void element, so set_html will make no affect to it's own html.
  2. so you should use replace_with, and the replace_with method will replace its parent's html with the new html by using the set_html method, but here is a limitation: the document-fragement root element can't use set_html method, maybe it's a issue should be fixed.

I hope it will fix your issue, any problem you can continue comment in this issue. thx again!

from visdom.

1984204066 avatar 1984204066 commented on August 15, 2024

from visdom.

1984204066 avatar 1984204066 commented on August 15, 2024

Yes use Vis::dom(img).replace_with(&mut new_img); works, great thanks.

Though
println!("1. {}", img.outer_html());
still output old value, ofcourse it still reasonable, because we can think calling Vis::dom changes the dom, not img itself.

But if i call this way:

                    let mut new_img = Vis::load(new_img).unwrap();
                    let it = new_img.get_ref().iter().next().unwrap();
                    println!("{}", it.as_ref().outer_html());
                    img.replace_with(it);    // takes effect after leave for_each. Delayed
                    println!("1. {}", img.outer_html());  // output old value.

When you leave the for_each, the content changed, this means img.replace_with(it) is correct.

My question is should I expect the img.replace_with(it); should take effect immediately, so println!("1. {}", img.outer_html()); should print new value?

Of course the delayed effect of img.replace_with(it) not bother me, but from semantic meaning it should take effect immediately I think.

from visdom.

fefit avatar fefit commented on August 15, 2024

@1984204066 I understand what you mean, the replace_with method can replace the element with not only one target elements, so it will only change the parent element but not itself, consider most people will only replace one element to another, and from the semantic, maybe it's useful to change itself too. later i will publish a new version to support it. thx your advice!

from visdom.

fefit avatar fefit commented on August 15, 2024

@1984204066 the new version v0.5.9 has published, you can have a try~

from visdom.

1984204066 avatar 1984204066 commented on August 15, 2024

from visdom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.