a couple minor nitpicks about feathersui-openfl HOT 8 CLOSED

Is for (item in items) guaranteed to be in order? Even if that's the case, I'm somewhat wary because it's not always true in other languages. I'd rather have code that doesn't require remembering how something behaves.

so probably using Std.downcast is better in this case.

Just to be sure that I fully understand, can you post an actual code example of the change that you're suggesting?

from feathersui-openfl.

Is for (item in items) guaranteed to be in order? Even if that's the case, I'm somewhat wary because it's not always true in other languages. I'd rather have code that doesn't require remembering how something behaves.

Ordering depends on a collection/iterator, and since Array is an ordered collection, of course it's guaranteed to be in order. I think that's the same for every language that supports "declarative" for.

can you post an actual code example of the change that you're suggesting

Something like:

var layoutObject = Std.downcast(item, ILayoutObject);
if (layoutObject != null && !layoutObject.includeInLayout) {
    continue;
}

from feathersui-openfl.

Is for (item in items) guaranteed to be in order? Even if that's the case, I'm somewhat wary because it's not always true in other languages.

Huh? In what language is this not the case?

from feathersui-openfl.

JS/AS would come to my mind, because there it means key iteration. But for/of (which is the actual counterpart to Haxe's for/in) is indeed well defined for arrays.

from feathersui-openfl.

JS/AS would come to my mind, because there it means key iteration.

AFAIK the order of "keys" for Array is still defined there.

from feathersui-openfl.

AFAIK the order of "keys" for Array is still defined there.

Sorry to disappoint, but I have bad news for you:

There is no guarantee that for...in will return the indexes in any particular order. - MDN

IIRC AS2 would rather consistently give the array keys to you in reverse order ¯\_(ツ)_/¯

from feathersui-openfl.

IIRC AS2 would rather consistently give the array keys to you in reverse order ¯_(ツ)_/¯

LOL, but oh well, as you already mentioned, Haxe for is different and more properly "maps" to ES6 for/of loops, or e.g. C# for each, so one should not be afraid to use it and it has better expressiveness.

from feathersui-openfl.

@nadako Unfortunately, this code that you suggested does not work:

var layoutObject = Std.downcast(item, ILayoutObject);
if (layoutObject != null && !layoutObject.includeInLayout) {
    continue;
}

Compiler error:

Constraint check failure for downcast. feathers.layout.ILayoutObject should be openfl.display.DisplayObject

from feathersui-openfl.