Code Monkey home page Code Monkey logo

Comments (8)

featdd avatar featdd commented on August 16, 2024

Would you mind to tell me your PHP version and check your HTML for correctness?
I can't reproduce this error but it could be some kind of endless loop when DOMNode tries to resolve its path in the xml tree and a closing tag is missing or something.

Greetings
featdd

from dpn_glossary.

RauchF avatar RauchF commented on August 16, 2024

I'm using PHP 5.5.23.

I've checked the HTML, it contains no errors according to https://validator.w3.org/nu/ .

edit: Sorry about closing it, my cursor slipped.

from dpn_glossary.

featdd avatar featdd commented on August 16, 2024

Hm thought it could have been some broken html otherwise I can't explain the crash at getNodePath for now. It just resolves the xml tree so I can check if the tag I want to parse has parents which are not allowed. Even on big html files it should'nt exceed the maximum execution time :-/

from dpn_glossary.

RauchF avatar RauchF commented on August 16, 2024

Here's my constants for dpn_glossary, if it helps. You'll notice I set the forbiddenParentTags to an empty string:

plugin.tx_dpnglossary.settings.parsingTags = p,span,a,h1,h2,h3,h4,h5,h6
plugin.tx_dpnglossary.settings.forbiddenParentTags =
plugin.tx_dpnglossary.persistence.storagePid = 24

edit: I've created a Gist with the source of the page here: https://gist.github.com/RauchF/d7a5da773cb35ac02d6f

from dpn_glossary.

featdd avatar featdd commented on August 16, 2024

Ah thats the snag. you don't want to parse a tags and want them to be forbidden as parent, because you dont want a link generated in a link.

I will take a look into my code to catch if no forbiddenparenttags were set but I highly recommened to keep "a" as default and remove the "a" from your parsingtags.

from dpn_glossary.

RauchF avatar RauchF commented on August 16, 2024

Ah, that's the thing. I'm not planning to use a detail or list view (and thus have no need for links), but basically just <abbr>, <acronym>, etc with their title attributes (as is possible with a21glossary from the government package). Is that behaviour supported? We use a21glossary on a couple sites at the moment, but we're looking to move to a more actively developed and supported extension (a21glossary only works with the compatibility6 extension currently and is also still stuck on piBase).

from dpn_glossary.

featdd avatar featdd commented on August 16, 2024

You can configure the behaviour as you like over the extension settings. Just look at the standard configuration and you'll see.

This extension is actively developed, so if you have any questions just ask.

from dpn_glossary.

featdd avatar featdd commented on August 16, 2024

Solved in f7d7ef2

from dpn_glossary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.