panic in the stats element about govpp HOT 5 CLOSED

Hello, thanks for the report. Please include information about the VPP version. Also, if possible perhaps including dump using vpp_get_stats for the retrieved data.

from govpp.

I have not done any code investigation, but from quick glance, my assumption of what is happening here is that some interface got deleted during the update of stats entry data.

This commit is possibly related to this: FDio/vpp@ff27c9f

I see two solutions to be explored:

1. Catch the panic at the updateStats in the core package and re-allocate the memory with interface stats data. This should avoid any future panics when access invalid data from stats segment.
2. Check the length of data on each read out of stats data, but this might affect performance when retrieving a large amount of stats data.

from govpp.

Thanks!
We use this VPP version - https://github.com/FDio/vpp/tree/1765f014bc7fcc3b924019ec96350eb50bef629f

I'm not sure, but I think that the creation of the interface occurred at the time the statistics were received. It seems we didn't remove the interfaces at that point

from govpp.

Hello @ondrej-fabry,

Can't we just use
vecLen = uint32(len(data))
instead of
vecLen := *(*uint32)(vectorLen(dirVector)) ?

https://github.com/FDio/govpp/blob/v0.8.0/adapter/statsclient/statseg_v2.go#L340-L341

from govpp.

@ondrej-fabry Any insight here?

from govpp.