Missing header-only target for libfmt in Debian about fcitx5 HOT 9 CLOSED

On Mon, Oct 9, 2017 at 1:50 AM Boyuan Yang ***@***.***> wrote: I found Debian's libfmt heavily patched. Among the patches exists the following one: From: "Eugene V. Lyubimkin" ***@***.***> Date: Sat, 24 Sep 2016 16:14:24 +0200 Subject: fmt: cmakelists: remove header-only targets For Debian, client code shouldn't try to compile .cc-files by itself but instead use a static library compiled by this package. This also really separate sources with headers. Otherwise the install target will install also .cc-files to /usr/include.--- fmt/CMakeLists.txt | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/fmt/CMakeLists.txt b/fmt/CMakeLists.txt index 90eaf57..e5d151a 100644--- a/fmt/CMakeLists.txt+++ b/fmt/CMakeLists.txt@@ -1,7 +1,6 @@ # Define the fmt library, its includes and the needed defines.-# *.cc are added to FMT_HEADERS for the header-only configuration.-set(FMT_HEADERS container.h format.h format.cc ostream.h ostream.cc printf.h- printf.cc string.h time.h)+set(FMT_HEADERS container.h format.h ostream.h printf.h string.h time.h)+set(FMT_SOURCES format.cc ostream.cc printf.cc) if (HAVE_OPEN) set(FMT_HEADERS ${FMT_HEADERS} posix.h) set(FMT_SOURCES ${FMT_SOURCES} posix.cc)@@ -34,19 +33,6 @@ if (BUILD_SHARED_LIBS) target_compile_definitions(fmt PRIVATE FMT_EXPORT INTERFACE FMT_SHARED) endif () -#-------------------------------------------------------------------------------# additionally define a header only library when cmake is new enough-if (CMAKE_VERSION VERSION_GREATER 3.1.0 OR CMAKE_VERSION VERSION_EQUAL 3.1.0)- add_library(fmt-header-only INTERFACE)- add_library(fmt::fmt-header-only ALIAS fmt-header-only)-- target_compile_definitions(fmt-header-only INTERFACE FMT_HEADER_ONLY=1)-- target_include_directories(fmt-header-only INTERFACE- $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>- $<INSTALL_INTERFACE:include>)-endif ()- # Install targets. if (FMT_INSTALL) include(CMakePackageConfigHelpers)@@ -57,9 +43,6 @@ if (FMT_INSTALL) set(targets_export_name fmt-targets) set (INSTALL_TARGETS fmt)- if (TARGET fmt-header-only)- set(INSTALL_TARGETS ${INSTALL_TARGETS} fmt-header-only)- endif () set(FMT_LIB_DIR lib CACHE STRING "Installation directory for libraries, relative to ${CMAKE_INSTALL_PREFIX}.") (You may retrieve Debian's source code here <http://ftp.debian.org/debian/pool/main/f/fmtlib/>.) @wengxt <https://github.com/wengxt> Any comments? It's a blocker for fcitx5 into Debian, let's keep this issue open. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAP2ZNdUj7DEbcew9pGan7uWdaWooyBOks5sqd47gaJpZM4Ptka3> .