problems with typescript about domutils HOT 4 CLOSED

Hi @0x0a0d, thanks for opening this, and sorry for never responding. I agree that the current DOM structure isn't ideal, and I am thinking about how to improve it. You point at real issues with the current types, and I'd like to keep the issue open — hope that's okay!

from domutils.

Okay, let's address this:

1. The issue here is el.parent?.name === 'body', as the parent isn't guaranteed to be a tag (it could also be the document). You can work around this with an additional check: el.parent?.type === 'tag' && el.parent.name === 'body'.
2. getElements is inherited from the original node-htmlparser project and provides filters for any kind of node. For a simple name filter, you can use getElementsByTagName; this will only return elements.
3. find similarly allows you to get any kind of node, while findAll is limited to elements. Agreed that this is confusing. I have added a documentation comment for now.

from domutils.

I found the correct way to do it

DomUtils.find(el=> el instanceof Element /* && any conditions */, children, false, 10) as Element[]

from domutils.

I think most of this has been resolved, even though there are still plenty of casts and type checks that are necessary.

from domutils.