Comments (3)
Hi @danshapero thanks for opening the issue! It would be great to have tqdm support in our downloader. The change should be made to HTTPDownloader
. Since this is not the current behavior, we should probably make it optional at first. If we want to make this the default, we can include a notice that it will be the default in a future release and a way to opt out so people can have time to adapt. Most projects use small test data so I imagine most people won't want this on by default.
One way to implement this would be to introduce a new progressbar=False
argument for HTTPDownloader
and add tqdm to the download loop if True
. This way, the bar will be off by default and people can turn it on by passing downloader=HTTPDownloader(progressbar=True)
to Pooch.fetch
.
This is a good reference for how to implement this: https://stackoverflow.com/a/37573701/1259381
What do you think?
from pooch.
Suits me, I've used tqdm before. Do you want to make it a hard dependency (add to setup.py and requirements.txt) or an optional one?
from pooch.
It can be optional for now since the behavior is off by default.
from pooch.
Related Issues (20)
- Pooch 1.7.0 fails when filenames have apostrophes HOT 9
- Download from URL with expired SSL certificate HOT 4
- Problem accessing public files on Dropbox HOT 4
- Add support for downloading from AWS S3 butckets HOT 1
- If Unzip/Untar fails because of a non-existent member, calling without members won't work HOT 2
- Feature: allow null hash in registry files HOT 3
- Make sure that any test that uses the network is properly marked HOT 1
- pooch.make_registry does not handle spaces in filenames correctly HOT 1
- `KeyError: 'key'` in ZenodoRepository.download_url() after Zenodo migration HOT 8
- Mention in docs that registry files must use POSIX compatible file names
- Release v1.8.0 HOT 1
- Sorry wrong repo for the issue HOT 1
- fatiando.org is down HOT 2
- Add "git blob hash" as available hash HOT 3
- Add or document support for Dryad via DOIDownloader HOT 1
- Add support for downloading from Azure cloud storage HOT 2
- Release v1.8.1 HOT 2
- Add support for downloading from Google Cloud Storage HOT 1
- Increase timeout on HTTP requests and use a variable HOT 3
- Inconsistent file hashes between operating systems HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pooch.