Code Monkey home page Code Monkey logo

Comments (3)

leouieda avatar leouieda commented on May 24, 2024

Hi @danshapero thanks for opening the issue! It would be great to have tqdm support in our downloader. The change should be made to HTTPDownloader. Since this is not the current behavior, we should probably make it optional at first. If we want to make this the default, we can include a notice that it will be the default in a future release and a way to opt out so people can have time to adapt. Most projects use small test data so I imagine most people won't want this on by default.

One way to implement this would be to introduce a new progressbar=False argument for HTTPDownloader and add tqdm to the download loop if True. This way, the bar will be off by default and people can turn it on by passing downloader=HTTPDownloader(progressbar=True) to Pooch.fetch.

This is a good reference for how to implement this: https://stackoverflow.com/a/37573701/1259381

What do you think?

from pooch.

danshapero avatar danshapero commented on May 24, 2024

Suits me, I've used tqdm before. Do you want to make it a hard dependency (add to setup.py and requirements.txt) or an optional one?

from pooch.

leouieda avatar leouieda commented on May 24, 2024

It can be optional for now since the behavior is off by default.

from pooch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.