Code Monkey home page Code Monkey logo

Comments (13)

KrauseFx avatar KrauseFx commented on March 29, 2024

This would result in one class of each tool, defining all available options, with a short description of what they're for.

We then iterate through all available options and pass it to commander

from fastlane.

joshdholtz avatar joshdholtz commented on March 29, 2024

@KrauseFx How does this effect #28 since that is added listening in an the --env option? I'm all for improving this! Just curious 😁

from fastlane.

dfranzi avatar dfranzi commented on March 29, 2024

I'm finding this to be particularly important with sigh, as it'd be great to be able to specify the file name and output directory from within fastlane when fetching provisioning profiles.

from fastlane.

KrauseFx avatar KrauseFx commented on March 29, 2024

I completely agree. Any feedback appreciated! I want to get this right when working on this issue.

from fastlane.

dfranzi avatar dfranzi commented on March 29, 2024

I've just started diving into developing a pipeline with fastlane, so I don't have the best insight into all use cases yet. With sigh in particular, I'd want to be able to define parameters per lane. The usage that I see would involve updating the sigh action to work with parameters in a similar manner to produce. This would enable me to define the parameters inline to the call, or as environment variables externally first.

from fastlane.

KrauseFx avatar KrauseFx commented on March 29, 2024

The current plan is to provide a ConfigurationManager-Class in the fastlane_core, which each individual tool can call with its available options.

From then on, each tool can call the ConfigurationManager and ask for specific values. If there was no command line option given, no configuration in the configuration file and no environment variable, it will ask the user for the value and show information on how to set this value programatically.

Thanks @joshdholtz 👍

from fastlane.

almassapargali avatar almassapargali commented on March 29, 2024

Hello, I think it may be a little late, since we already make a big use of ENV, but I'd propose to use ENV only for sensitive information.

For other information I think we should take from configuration file, fastlane options, and command line arguments (the latter overwrites former). What do you think of this?

from fastlane.

KrauseFx avatar KrauseFx commented on March 29, 2024

Why wouldn't we also allow passing of any information from the environment?

from fastlane.

almassapargali avatar almassapargali commented on March 29, 2024

I don't know, just think would be nice to have one place of input.

from fastlane.

almassapargali avatar almassapargali commented on March 29, 2024

Also maybe use something like this but generalised for all tools?

from fastlane.

almassapargali avatar almassapargali commented on March 29, 2024

Ok, I'll check out how other established tools (cocoapods, homebrew, etc.) handles this and write back.

from fastlane.

KrauseFx avatar KrauseFx commented on March 29, 2024

Started with the pull request: fastlane-old/fastlane_core#8

Will take a few more days until fully finished 🚀

from fastlane.

KrauseFx avatar KrauseFx commented on March 29, 2024

Everything except for the configuration file is finished 🚀

from fastlane.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.