Code Monkey home page Code Monkey logo

Comments (19)

mcollina avatar mcollina commented on June 22, 2024 1

I think we can switch to Netlify given (https://www.netlify.com/legal/open-source-policy) or Vercel (https://vercel.com/support/articles/can-vercel-sponsor-my-open-source-project).

Whatever you chose - I have contacts on both providers.

from website-metalsmith.

mcollina avatar mcollina commented on June 22, 2024 1

@luisorbaiceta if you include a badge https://www.netlify.com/press/#badges in the footer, I can request an OSS account from Netlify.

from website-metalsmith.

mcollina avatar mcollina commented on June 22, 2024 1

I would go ahead with Netlify unless somebody has a strong preference for something else. I don't know what would entail to pick Netlify vs something else (or roll our own). I'm just working to create a sponsored account for Fastify.

Do anyone have an objection in picking Netlify?

from website-metalsmith.

mcollina avatar mcollina commented on June 22, 2024 1

I have requested an OSS account from Netlify

from website-metalsmith.

mcollina avatar mcollina commented on June 22, 2024 1

As you prefer, you should have enough permissions for both - in case let me know.

from website-metalsmith.

luisorbaiceta avatar luisorbaiceta commented on June 22, 2024

@sinchang, in your experience with Netlify, do you think it could solve #312?

from website-metalsmith.

jsumners avatar jsumners commented on June 22, 2024

Really want to see this happen. It's very frustrating not being able to see how changes to docs in the main repo will affect the site without first merging into main.

from website-metalsmith.

luisorbaiceta avatar luisorbaiceta commented on June 22, 2024

Really want to see this happen. It's very frustrating not being able to see how changes to docs in the main repo will affect the site without first merging into main.

I'm afraid this is a consequence of the current build process and has nothing to do with the provider. A good solution would be to always work on the same branch the docs changes (wip/docs) and targeting that specific branch in the build process (like we do with master branch). We can leave that part hidden for the final user and only make it available by route access

from website-metalsmith.

jsumners avatar jsumners commented on June 22, 2024

I do not wish to complicate the core repo contribution workflow. The website build should be able to accommodate the normal PR process.

from website-metalsmith.

mcollina avatar mcollina commented on June 22, 2024

@luisorbaiceta it should be possible by triggering a rebuild using the API.

from website-metalsmith.

luisorbaiceta avatar luisorbaiceta commented on June 22, 2024

If changes have not been merged to master, there is no way to preview them without knowing the name of the branch those changes have been made in beforehand. See here

from website-metalsmith.

luisorbaiceta avatar luisorbaiceta commented on June 22, 2024

@luisorbaiceta if you include a badge https://www.netlify.com/press/#badges in the footer, I can request an OSS account from Netlify.

Should we choose Netlify then?

from website-metalsmith.

luisorbaiceta avatar luisorbaiceta commented on June 22, 2024

Great! Let me know when credentials are ready so I can start a PR to work on the new workflow

from website-metalsmith.

mcollina avatar mcollina commented on June 22, 2024

I'd need the badge to be there to do that.

from website-metalsmith.

luisorbaiceta avatar luisorbaiceta commented on June 22, 2024

Should we wait a reasonable time then to see if anyone has any objections with Netlify? If not, I have time to add it now

from website-metalsmith.

mcollina avatar mcollina commented on June 22, 2024

Open a PR, let's wait a day or two to land it.

from website-metalsmith.

jsumners avatar jsumners commented on June 22, 2024

No objections here.

from website-metalsmith.

mcollina avatar mcollina commented on June 22, 2024

@luisorbaiceta I have invited you to Netlify

from website-metalsmith.

luisorbaiceta avatar luisorbaiceta commented on June 22, 2024

Great! We can now trigger deploys by connecting the account to the repo, or by setting up a workflow from github actions. I'm fine with both approaches

from website-metalsmith.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.