Code Monkey home page Code Monkey logo

Comments (5)

climba03003 avatar climba03003 commented on May 27, 2024 1

Does the proposed solution not show that?

Yes, consider the follow code working properly without @autotelic/fastify-opentelemetry.
You should not force everyone to use async or return Promise.

instance.get('/ok', function(request, reply) {
  setTimeout(function() {
    reply.send('ok')
  }, 1000)
})

The occur of FST_ERR_REP_ALREADY_SENT is you are forking the promise chain.
The plugin you mention actually doing the following action.

// note the async here
instance.get('/ok', async function(request, reply) {
  setTimeout(function() {
    reply.send('ok') // you return to client inside timeout as well
  }, 1000)
  // you implicit return undefined which reply to client with empty string
})

from fastify-static.

climba03003 avatar climba03003 commented on May 27, 2024

I am closing this issue because nothing show the bug is exist inside this repository.
Please minimize your reproducible snippet without any other plugins.

from fastify-static.

climba03003 avatar climba03003 commented on May 27, 2024

My suggestion is remove the async from @autotelic/fastify-opentelemetry.
So, it will respect the original function.

from fastify-static.

10xLaCroixDrinker avatar 10xLaCroixDrinker commented on May 27, 2024

I am closing this issue because nothing show the bug is exist inside this repository. Please minimize your reproducible snippet without any other plugins.

Does the proposed solution not show that?

from fastify-static.

10xLaCroixDrinker avatar 10xLaCroixDrinker commented on May 27, 2024

Thanks for your help @climba03003. I opened a PR to @autotelic/fastify-opentelemetry.

from fastify-static.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.