Optional fields do not respect the Include.NON_NULL property [2.9.4] about jackson-modules-java8 HOT 3 CLOSED

Without actual unit test it's hard to say (printing out values is a bad way to demonstrate anything) for sure, but it seems to me like it is working as expected: Optional.ofNullable(null) is NOT null but an instance of Optional. And that will not be excluded with NON_NULL.

Instead, you should probably use NON_ABSENT which will exclude null as well as Optionals without content (case in test above). NON_EMPTY would similarly work, but would also exclude empty arrays, Maps and Collections.

from jackson-modules-java8.

I wrote it as a main since the behaviour is simple and can be easily verified but here is a test.

NON_ABSENT works, but I would argue that NON_NULL should probably encompass the behaviour since the main use of Optional is null safety and Optional.empty signifies a null field anyway.

Regardless I suspect that this is a philosophical argument so feel free to close.

from jackson-modules-java8.

Definition of NON_NULL is strictly that it relates to Java null value and nothing else.
NON_ABSENT was added to address the case for Optionals and similar reference types (AtomicReference, Guava, Scala Option).

from jackson-modules-java8.