Code Monkey home page Code Monkey logo

Comments (3)

cowtowncoder avatar cowtowncoder commented on June 1, 2024

I think a unit test (piece of code) that reproduces the issue would help here, to ensure specifics of how characters are escaped in code.

Also: which Jackson version is this with?

from jackson-dataformats-text.

tabalinas avatar tabalinas commented on June 1, 2024

Thank you for the quick response!

Sure, a unit test to reproduce the issue:

@Test
public void escapeCharAndNullValueConflict() throws IOException {
    String csv = "id,value\n" +
            "1,\\N";

    InputStream in = new ByteArrayInputStream(csv.getBytes(StandardCharsets.UTF_8.name()));

    CsvSchema schema = CsvSchema
            .emptySchema()
            .withHeader()
            .withColumnSeparator(',')
            .withEscapeChar('\\')
            .withNullValue("\\N");

    MappingIterator<ObjectNode> it =
            new CsvMapper().readerFor(ObjectNode.class).with(schema).readValues(in);

    ObjectNode row = it.nextValue();

    assertThat(row.get("value"), is(nullValue()));
}

which fails with:

Expected: is null
     but: was <"N">
java.lang.AssertionError: 
Expected: is null
     but: was <"N">
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:865)
	at org.junit.Assert.assertThat(Assert.java:832)

We use Jackson v2.8.8.

from jackson-dataformats-text.

cowtowncoder avatar cowtowncoder commented on June 1, 2024

Hmmh. I am not 100% sure what the logic should be, and due to the way tokenization is done it may be that this is considered feature, not bug. The problem is that replacement of null value is higher level operation and occurs after tokenization; escape characters are, however, handled during tokenization.

But I can see why this may be problematic so I will keep this open to see if handling could be improved.

from jackson-dataformats-text.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.