Comments (4)
ffulin
commented on September 27, 2024
Thanks for reporting this potentially nasty bug!
Indeed the logic is not correctly accounting for the exectuable name and the quotation of the exe name that is necessary to cope with paths with spaces in them. Conceptually the fix needed is what you've shown.
I'll work on getting a fix for that in place that covers all the users of response files.
(This logic is Windows-specific, since only windows compilers generally utilize response files since they are only necessary to work around the length limits in the Windows API.)
from fastbuild.
ffulin
commented on September 27, 2024
I've submitted a fix for this in the Perforce mainline. The fix will be in the next release (v0.88). I'll leave this issue open until that is released.
I turned out to need quite a rework in order to be robust in all cases: there were quite a few egde-case bugs which the rework addresses.
Thanks again for reporting the bug!
from fastbuild.
ndob
commented on September 27, 2024
Great, thanks!
from fastbuild.
ffulin
commented on September 27, 2024
v0.88 has now been release and includes a fix for this issue (as well as some other command line length edge cases).
from fastbuild.
Related Issues (20)
- C++20 module support HOT 3
- Missing dependencies when using array as `.CompilerInputPattern` HOT 8
- Missing XML Quoting support in vcxproj generator HOT 4
- integration Distributed ThinLTO with FASTBuild HOT 7
- `-compdb` does not include commands to generate PCHs HOT 1
- Problem using variable inside #include HOT 2
- Configuration file supporting Libraby and executable HOT 2
- Visual Studio Instrumentation profiling integration? HOT 5
- ObjectList not rebuilt when PreBuildDependencies changes HOT 4
- .CompilerOptionsC option HOT 16
- How to make full use of the build server HOT 3
- FASTBuild 1.13 gives false "Missing precompiled header option Yc in PCHOptions" error when Yc is present HOT 2
- Problems with compressed source files (LNK2019 error) HOT 7
- Compilation fails with 4> clang: error: invalid Xarch argument: '-Xarch_arm64 -o', options requiring arguments are unsupported HOT 3
- fbuild <target> emits warning while there are no warnings in the cl output HOT 1
- warning LNK4042 when linking a library from several ObjectLists that reused the same PCH. HOT 2
- Limit number of cores used for linking HOT 3
- 'Exec' can't have 'ObjectList' node specified as '.ExecInput' HOT 1
- Show remaining tasks in the status line, and document it HOT 3
- -report=json produces malformed output when caching is disabled HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastbuild.