Callbacks - "begin_epoch" always called 2x... about fastai_dev HOT 2 CLOSED

Well the bug is here in notebook 9b:

ALL_CBS = {'begin_batch', 'after_pred', 'after_loss', 'after_backward', 'after_step',
'after_cancel_batch', 'after_batch', 'after_cancel_epoch', 'begin_fit',
----> 'begin_epoch', 'begin_epoch',
'begin_validate', 'after_epoch',
'after_cancel_train', 'after_fit'}

Note how begin_epoch is listed 2x.

from fastai_dev.

try:
self.do_begin_fit(epochs)
for epoch in range(epochs):
self.do_begin_epoch(epoch) --> This calls begin_epoch()
#if not self('begin_epoch'): self.all_batches() --> This calls begin_epoch() again.

            with torch.no_grad():
                self.dl = self.data.valid_dl
                if not self('begin_validate'): self.all_batches()
            self('after_epoch')

I modified the code following :
try:
self.do_begin_fit(epochs)
for epoch in range(epochs):
begin_epoch = self.do_begin_epoch(epoch) --> This calls begin_epoch()
#if not begin_epoch: self.all_batches() --> This calls begin_epoch() again.

            with torch.no_grad():
                self.dl = self.data.valid_dl
                if not self('begin_validate'): self.all_batches()
            self('after_epoch')

Now working as expected. But I am not sure of any side effects.

from fastai_dev.