Comments (4)
return static::isProduction() ? 'https://apiom.orange.bf:9007/payment' : 'https://testom.orange.bf:9008/payment';
I don't think the URL should be hardcoded into the project. This should be moved into the
.env
file. If Orange should update its API URL, everyone using this package will have to wait for the maintainers to update the code. I suggest leaving it open for modification by the users of the package.I can make a PR.
Yes i agree.
from orange-money-burkina-sdk.
So I will close the #17 PR and make another with the changes discussed on the review.
from orange-money-burkina-sdk.
So I will close the #17 PR and make another with the changes discussed on the review.
it's okey for me
from orange-money-burkina-sdk.
@tsommie can you close this issue now ?
from orange-money-burkina-sdk.
Related Issues (11)
- Change default branch from master to main HOT 1
- Using a strict float type-hint for amount. HOT 4
- Property visibility scope. HOT 4
- do you have any nodejs implementation for OM? HOT 1
- Uncaught TypeError: strlen() expects parameter 1 to be string, null given ,ligne 92 OMSDK.php HOT 1
- cURL error code 28 HOT 3
- any plan for nodejs sdk ?
- Failed to connect to apiom.orange.bf port 9007 after 128785 ms: Connection timed out
- Notice: Undefined property: stdClass::$status
- Make api response more frendly HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orange-money-burkina-sdk.