Manipulating headers about kafkaflow HOT 7 CLOSED

Using context.Headers.SetString("Message-Type", string.Empty) works as a workaround for erasing specific headers but will leave this open for proper solution.

from kafkaflow.

Hi @mhkolk ,
Headers were defined as read-only by design, as they represent the message headers, which should not be editable; as an example of the same design principle, you can look at HttpRequestMessage.
In the IMessageContext, you have the Items property, a dictionary, that you can use, adding there some data you may find useful for the message context.

from kafkaflow.

If we're using KafkaFlow for producing and have the ability to use middleware to manipulate messages I think it makes sense to allow manipulating headers (on the producer side). Developer using KF should be responsible for proper usage.

from kafkaflow.

In the IMessageContext, you have the Items property, a dictionary, that you can use, adding there some data you may find useful for the message context.

This was more about removing stuff than adding. The ability to add is already present

from kafkaflow.

Hi @mhkolk,

The reason the headers collection does not allow that kind of manipulation is that it can introduce dependencies between the middlewares which is not something to encourage, since it is expected that the header collection represents the headers present in the Kafka message.

Is there any use case where the current implementation is blocking you from using KafkaFlow?

from kafkaflow.

It was just a suggestion, I worked around it by using SetString, so it is not a blocker.

from kafkaflow.

Thank you for the feedback @mhkolk.

In the future, if this question is raised again we can revisit this subject, but for now, we should leave it as-is.

We will be closing this issue. Please feel free to respond to this message or reopen the issue if you'd like to continue the discussion or if you've encountered any new developments related to it.

Thank you for your contribution.

from kafkaflow.