Still having problems with required: false about backbone-validator HOT 11 CLOSED

Isn't it reasonable that empty field is failing on minLength? I'd say that in such cases it's good to go with custom validation using fn validator:

validation: ->
  name:
    fn: -> (value)
      value || value.length >= 3
    message: 'Name is too short'

Thoughts?

from backbone-validator.

On the other hand you're probably right, it makes sense to run length check only if value is present, which could be controlled via required

from backbone-validator.

Yeah, that was my initial instinctive reaction, however you could make a good case for either, I suppose.

from backbone-validator.

But that means required must be considered in all validations, which I've been trying to wrap my head around in either the Validator.validate or the Validator._validateAll function.

from backbone-validator.

I think it's possible just to check whether attribute value is not empty in such attributes without checking for required. So all string validators (minLength, maxLength, format) will run only if string is not empty.

from backbone-validator.

Hmm but if someone does not have required specified, you'd still want to run minLength even if the string is empty...

from backbone-validator.

Yep, in this case you have to add required: true :)
It's a kind of tricky case to decide how to validate strings here, but using validators only on non-empty strings making it a bit more flexible as you can always define that value should not be empty with required validator

from backbone-validator.

I see your point. Just because you specified a minLength doesn't necessarly mean the field should be implicitly required... and I see why the format validator has been passing anyway, but the minLength and maxLength check that a value is there, so they weren't. : )

from backbone-validator.

Yeah, that's the inconsistency that should be fixed

from backbone-validator.

It's always good to see solutions that take barely any code. Let me take this chance to say thanks for building a small and effective validation plugin, and keeping up with maintenance! : )

from backbone-validator.

👍

from backbone-validator.