Comments (32)
Hi, I'm the maintainer of Simple Icons. Once you're ready, PRs are welcome. Feel free to ping me if you need help with contributing.
My suggestion for the badge is to use the whiteish color for the left-side background. For example:
<!-- I used the foodpanda icon as an example since your logo is not on Simple Icons yet. -->
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=fff)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=eee)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=ddd)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=fff&style=flat-square)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=eee&style=flat-square)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=ddd&style=flat-square)
from faker.
face-filled-1
wins for me
from faker.
Team Decision
- We will use
face-filled-1
- We will create a PR to upload the icon there.
from faker.
to add a badge to my readme file indicates i'm using fakerjs in my project.
from faker.
from faker.
I think I found my favorite and decided (for me)
from faker.
For what purpose do you need the logo?
from faker.
I mean, it gives for the people who use it and doesn't harm anybody who doesn't use it 🤷
Why would you open an issue here instead at the simple icon repo, tho? 🤔 (I have no idea how the process works)
from faker.
I mean, it gives for the people who use it and doesn't harm anybody who doesn't use it 🤷
I don't know if this issue can harm anybody.
Why would you open an issue here instead at the simple icon repo, tho? 🤔
I guess the author has a better idea about how the icon should look like.
(I have no idea how the process works)
https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon
from faker.
I don't know if this issue can harm anybody.
What I wanted to say is: This "features" look very low effort/maintainable for us. So it would not hurt to give it a try.
I guess the author has a better idea about how the icon should look like.
I see (and also read it in the affiliate section in their contributions guidelines). Guess we can discuss it on this week's team meeting.
https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon
Thank you for the link. I was already reading their documentation and intended to rework my comment with a funny twist like: "(I don't know how their process works) I got it now!"
I did not expect you to answer this fast 😄
from faker.
How about this one. It is based on https://github.com/faker-js/faker/blob/next/docs/public/logo.svg
We might have to clean it up some more though, because at low screen sizes it gets indistinguishable.
from faker.
The outline is good, could you add some color to it? Otherwise, it would be very dark on a dark background.
from faker.
The icons have to be black and transparent. I can add a white background for better visualization on darkmode.
from faker.
looks cool
from faker.
Here a variant with only the face:
from faker.
IMO it is still very had to see properly when small.
Maybe we have to focus just on the face and maybe fill it/invert the interior.
from faker.
Here vitest for comparison:
from faker.
Or just the magic hat?
from faker.
face-2
from faker.
Or just the magic hat?
I'll try that tomorrow.
from faker.
hat-1
from faker.
![image](https://private-user-images.githubusercontent.com/20043230/323452336-24f379f3-5ee1-497d-8336-c37b409ffcaf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTYzMjg1NTksIm5iZiI6MTcxNjMyODI1OSwicGF0aCI6Ii8yMDA0MzIzMC8zMjM0NTIzMzYtMjRmMzc5ZjMtNWVlMS00OTdkLTgzMzYtYzM3YjQwOWZmY2FmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTIxVDIxNTA1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIyYmI4MWM5YWRhM2UzMjRjYjFkNzlkM2RlNTE2MjExYTlhMDMwZDUyNjFhMmUzMzUxZGVhYjlhNGY2Y2ViYWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.NvuH_Z1xR60gH5mtBlDo3lrjHek4leRxVoVcyd74hhU)
from faker.
I think the panda head is most visible at small sizes.
from faker.
Please don't forget that there is usually no white background:
from faker.
the icon color can be set here btw https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#7-update-the-json-data-for-simpleiconsorg
Panda head or magic hat works for me.
from faker.
I will make some more variant soon.
Especially those with filled faces with default and no rotation.
from faker.
from faker.
dont like :(
from faker.
from faker.
from faker.
For better comparison:
from faker.
I'm "soft blocking" this issue as I'd like to talk about UI/UX related topics in our next teem meeting, next thursday.
from faker.
Related Issues (20)
- Speed up normalisation code HOT 8
- Release Checklist v9.0.0-alpha.0 HOT 1
- Localization lastName is not working HOT 2
- Phone numbers should support special numbers HOT 1
- Check capitisation of ex_MX/color/human
- Add v9.fakerjs.dev
- [Website] Change Navigation Behaviour HOT 4
- Generate Planet names HOT 9
- More varied product descriptions HOT 2
- Can't use Faker with k6 HOT 16
- Vehicle data is very US-centric HOT 1
- Improve specification of lorem module and definitions HOT 6
- Add plugin support for modules HOT 2
- Check whether complex objects should be frozen HOT 3
- Reevaluate word distribution
- Create Intl based tests for date definitions HOT 3
- Check whether the locale data should use locale aware sorting HOT 6
- 'lorem.words' missing for zh_CN HOT 5
- Use singular locale definition keys HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from faker.