How to match System.Security.Cryptography.Oid instances more easily? about fakeiteasy HOT 6 CLOSED

Hi @drauch,

We don't currently have a mechanism to register global comparers (maybe it would be something to consider).
However, you could use An<Oid>.That.IsEqualTo(expectedOid, oidComparer).
I realize it's not as convenient, and isn't much simpler than what you currently have, but it's slightly better...

from fakeiteasy.

maybe it would be something to consider

I'm of 2 minds. I appreciate the power of our existing extension endpoints, and this would totally mirror an extension for formatting argument values, but I don't love how hard they are to discover.

Still, overall, I do like the idea. It might even be a way to implement an enumerable-comparing scheme that we've been throwing around in the back of our minds (which we should really make an issue for).

from fakeiteasy.

Thank you for the - as always - quick replies. Bummer, that this is not possible, but that's life ;-)

If you favor discoverability: it could be a method at the end of the call chain, e.g., MustHaveHappened().UsingArgumentEqualityComparers<Oid>(new OidComparer()) and in my solution I would build a MustHaveHappenedWithMyComparers() extension method that combines the two (though I really like the possibility to do that in a "hidden" way too).

Best regards,
D.R.

from fakeiteasy.

@drauch, I appreciate the idea of a MustHaveHappened().UsingArgumentEqualityComparers<Oid>(new OidComparer()), but am not sure how it would buy you much over the solution you've come up with or that @thomaslevesque suggested. It would require a change to the library and still be pretty wordy. Granted, it's explicit, which is a nice feature, but we have explicit solutions that work with the current releases. Maybe I'm missing an advantage?

Perhaps I'm confused because I didn't understand

and in my solution I would build a MustHaveHappenedWithMyComparers() extension method that combines the two

Which two?

Regardless, I did create #1952 in case @thomaslevesque is also warm to the idea of the registry implicit argument comparers.

from fakeiteasy.

Maybe I'm missing an advantage?

It's better discoverable, but apart from that I don't like it much either.

Which two?

I'd hide MustHaveHappened().UsingArgumentEqualityComparers<Oid>(new OidComparer()).UsingArgumentEqualityComparer<Other>(new OtherComparer>()... behind a MyMustHaveHappened() extension method.

Regardless, I did create #1952 in case @thomaslevesque is also warm to the idea of the registry implicit argument comparers.

Great, I think we can close this issue then?

Best regards,
D.R.

from fakeiteasy.

Oh! I didn't realize you were proposing multiple UsingArgumentEqualityComparerss tacked onto the end. Thanks. I understand the extension method now. Yeah, I prefer the implicit comparer to a chain of explicits too.

Great, I think we can close this issue then?

100% my goal in creating the new one. Thanks!

from fakeiteasy.