Comments (6)
Concerning what's been done for the pallet-roles:
- Added a roles
storage_Map
, with the associated functionget_role()
which takes an account, and returns the corresponding role - WaitingList was renamed role_approval_list
- removed
nft_index
item from all roles structs
Concerning the removal of roles, several implications need to be considered before going forward, so this will require a team meeting.
from fair-squares.
- set_manager was changed as we detected that during testing,
from fair-squares.
Code pushed concerning the point 1. of housing fund. The housing_fund pallet uses the roles pallet to check if an investor is calling contribute or withdraw methods.
from fair-squares.
Based on the roles-pallet:
The extrinsic reads roleModule, housingFundModule —> These can be named roles and housingFund
- We can create a role, but we cannot destroy it? Users should be albe to get rid of a role
- After setting a role, I cannot check in the chain state what my role is ? —> Chain state —> Role-module —> getRole
- WaitingList should maybe be more descriptive —> RoleApprovalList
- In the log it's nice we can select per AccountID, but the roles should not keep up with the assets, talking about nftindex.
[
{
accountId: 5FHneW46xGXgs5mUiveU4sbTyGBzmstUspZC92UhjJM694ty
nftIndex: []
age: 50
}
]
- Set-manager gives me badOrigin error in all possible ways
from fair-squares.
In the housingFund
- I can contribute to the housing found with a fresh dev chain
cargo run --release -- --tmp --dev
with out taking any role.
Also if In take another role I can contribute. Don't understand how our tests are passing ? Think we haven't created one where we don't want an other role than the investors to fund. or that if you have no role set you can't fund at all. - Would be nice to also have some cross testing with other modules the example above could save us a lot of time when in the future we would add new features.
from fair-squares.
- in
housingFundModule.fundBalance
contributed is the metric that would count when an asset it bought from the fund? If so this should not be registered under the housingFundModule, but rather the history of the houseId @letodunc - rename to
SetRole
instead ofCreateAccount
as the account is easily misunderstood for accountId @ndkazu - in
account_approval
it would be more real and future-ready if like a receipt, so if a role verifier gives green light for a role, it also has a mandatory proof section. - roles maybe in small caps instead of just caps
from fair-squares.
Related Issues (20)
- Bidding Pallet - Update process_onboarded_assets
- Add Identity Pallet and Configuration Genesis
- Add Finalization pallet
- Representative_vote blocks
- Propose a tentant HOT 1
- Voting Management
- In asset_management => additionnal check needed on `launch_tenant_session` extrinsic
- Runtime panic: When an asset is finalized before an investor list is assembled HOT 2
- Fees and Deposits table
- Tenancy Pallet HOT 1
- implement ROR
- Pallet_payment
- Update approval waiting list management HOT 2
- Asset shares weights are not used for referendum voting.
- Add Event for maintenance fees
- Additional asset management request by a representative
- Additional preimage bug
- Security issue
- Testnet launch
- [REFACTORING] Upgrade to `polkadot-v0.9.40` and rewrite-optimise pallet_Roles HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fair-squares.