Code Monkey home page Code Monkey logo

Comments (9)

facelessuser avatar facelessuser commented on June 19, 2024

Yup, this is using official Dracula colors: https://github.com/dracula/dracula-theme#color-palette. I'm not saying it isn't flawed though.

So this matches the official color palette:

Screen Shot 2020-11-02 at 1 30 32 PM

I personally prefer something a little more based off the background:

Screen Shot 2020-11-02 at 1 33 38 PM

from sublime-dracula-scheme.

facelessuser avatar facelessuser commented on June 19, 2024

I'm not sure if there is anything I should do here. This scheme is meant to follow the Dracula color scheme as specified. I can maybe see us adding a custom one that takes an opinionated approach with some of the color contrasting...or the whole project can just deviate with an opinionated approach...

I mean, I don't have to provide a pure Dracula experience, but this is mainly provided as a modern Sublime color scheme compared to the official one still locked on to the old tmTheme style.

When using classic style, I'm often using a classic style based my spin on the Pro color scheme. Unfortunately, I have not released these:

Text - Classic

from sublime-dracula-scheme.

rwols avatar rwols commented on June 19, 2024

This scheme is meant to follow the Dracula color scheme as specified.

Okay.

from sublime-dracula-scheme.

facelessuser avatar facelessuser commented on June 19, 2024

I'm going to leave this open as I decide what I want to do. I generally agree that the selection highlight is a little poorly selected. Originally this was meant to provide a base for the official color scheme to work off of so they could update their old tmTheme file, but they've kind of sat on that issue, and it looks like they are content with the old tmTheme 🤷. I can do whatever I want here, I just need to decide what that is.

from sublime-dracula-scheme.

facelessuser avatar facelessuser commented on June 19, 2024

Maybe, at the very least, we can provide some suggested overrides in the readme. That is if we want to ship a pure Dracula color scheme, but provide improvements.

from sublime-dracula-scheme.

rwols avatar rwols commented on June 19, 2024

Apologies for being brief. My thought was: what does the community gain by this being a reference implementation of Dracula? Make it your own and improve it I say :)

from sublime-dracula-scheme.

facelessuser avatar facelessuser commented on June 19, 2024

That's fair, and what I've been grappling with. I'm already doing that on my private branch. Why not here as well.

from sublime-dracula-scheme.

facelessuser avatar facelessuser commented on June 19, 2024

I've decided to add a variant called Dracula (Alucard). I will leave the original Dracula unaltered for those who prefer the classic Dracula "proper". And for those who wisha custom variant, they can use the Alucard variant. I will update the Merge theme as well to provide an Alucard variant theme (one that uses the Alucard scheme.

from sublime-dracula-scheme.

facelessuser avatar facelessuser commented on June 19, 2024

Alucard color scheme and Merge theme are available. I don't really enable line highlights in Merge, but if people do, the Alucard Merge variant will use the new line highlight color.

from sublime-dracula-scheme.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.