Packageify fastMRI about fastmri HOT 6 CLOSED

We can move the banding removal code under experimental perhaps? I am hesitant to try to combine it with the rest of the code-base as even a minor change may break reproducibility.

from fastmri.

Very good proposal. This will result in a common train, valid, evaluate code for any new model and datasets. Is this open for contributions?

from fastmri.

This is an open source repository - of course! If you have some area that you'd like to prioritize perhaps post it here so that we don't duplicate efforts.

from fastmri.

That seems reasonable to me. It would be nice to get a basic implementation into fastmri at first, and for reproducibility we won't deprecate the current folder until we have enough time to verify everything vs. the paper. It's a big one compared to the others.

from fastmri.

If you have some area that you'd like to prioritize perhaps post it here so that we don't duplicate efforts.

Actually, I am using the older version of fastMRI code, the one without pytorch lightning. I even changed the varnet code to the older style. Now I am trying to bring different models using that code base.

You continue with pytorch lightning, I will share the code base with the old code style once I have it ready for atleast 2 or 3 models.

Thank you.

from fastmri.

At this point the core components of the refactor have been finished from the former code and new models have been updated to the leaderboard. The codes for generating the leaderboard models are now in experimental/varnet/varnet_brain_leaderboard_submission_2020-08-21.py and experimental/unet/unet_brain_leaderboard_submission_2020-08-18.py.

It's still undecided on PyPI distribution - might need to discuss around about this. It's also undecided whether we might want to move the PyTorch Lightning training modules in to the main package folder for distribution or leave them in experimental.

from fastmri.