Code Monkey home page Code Monkey logo

Comments (5)

pedroerp avatar pedroerp commented on August 21, 2024

Cc: @assignUser @kgpai

from velox.

assignUser avatar assignUser commented on August 21, 2024

The Fuzzer job you circled in the screenshot is expected to fail for reasons unrelated to the PR some times, though this failure looks like it found an actual issue maybe @pedroerp ? https://github.com/facebookincubator/velox/actions/runs/9942173218/job/27464421554?pr=10465#step:6:54

The performance report shouldn't fail on reasons unrelated to the PR but sadly it sometimes does due benchmarking being difficult ^^ In this case it's a pretty clear outlier/false positive https://velox-conbench.voltrondata.run/compare/benchmark-results/06683349688c788b80003ec3bf313991...06694cbdf2b875c58000ac8dd9cc4078/

from velox.

kevincmchen avatar kevincmchen commented on August 21, 2024

@assignUser then what should i do, if i want to commit this pr successfully ? recommit it ?

from velox.

assignUser avatar assignUser commented on August 21, 2024

I am not sure what the meta internal rules are but afaik red Fuzzer jobs and performance reports are only prevent a merge when they are related to changes you made (which these are not)

from velox.

kevincmchen avatar kevincmchen commented on August 21, 2024

I also think so, could you please look into this issue deeply? @pedroerp @assignUser

from velox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.