Comments (8)
not just that, we have some sample code also have fbcode dependencies.
is there somewhere we can move them to ?
from nifty.
We should certainly be able to make a version of nifty without the nifty-fbcode-... artifacts if we needed to opensource this before merging these parts.
from nifty.
Do those internal artifacts contain things that should or shouldn't be part of the open source Thrift release?
from nifty.
Yeah they contain an unreleased internal version of thrift.
from nifty.
Oh sorry, I guess you mean the internal nifty artifacts (with 'fbcode' in the artifact name). Those depend on that internal thrift version instead of the open source version and take advantage of one or two currently internal-only features, so they probably shouldn't be open-sourced just to prevent confusion.
To be clear there is nothing really in the internal thrift AFAIK that we wouldn't eventually want to opensource anyway, its just that apache thrift and internal thrift have diverged.
from nifty.
Sorry, I was referring to the internal thrift artifacts. The main issue with releasing it would be that you can't build the project. There's also the issue that you want to push all the artifacts to Maven OSS as part of the release, and they might not be allowed due to unresolved dependencies (at minimum they would be useless to anyone outside FB).
from nifty.
So if we can't easily open source the internal thrift, or if the fbcode modules are not useful outside of FB, it might be best to put them in a separate nifty-fbcode
repository.
from nifty.
I've created nifty-fbcode and will be moving fbcode related code there.
from nifty.
Related Issues (20)
- Does nifty plan to support Thrift0.9.1 HOT 2
- Support for multiplex protocol HOT 2
- NettyServerConfigBuilder instead of NettyConfigBuilder HOT 5
- Publish jars to OSS Snapshots HOT 1
- Compressed Transport HOT 1
- Proper timeout (and other exceptions) handling HOT 1
- Client support to support dynamic host set
- NiftyExceptionLogger.java probably shouldn't log at error severity for broken connections HOT 1
- Upgrading netty
- jdk8 HOT 1
- buffer overflow? `Maximum frame size of -2147483648 exceeded ` HOT 6
- Expose request queue metrics
- Upgrading netty !!!!! ?
- Test RSA certificate in netty-examples will expire in early 2017
- cancelAllTimeouts?
- nifty support thrift async server in libthrift - 0.9.1?
- Long time no update for this HOT 3
- HTTP content length exceeded 16777216 bytes HOT 1
- Is there any doc?
- Will this project continue to be updated? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nifty.