Code Monkey home page Code Monkey logo

Comments (7)

appleguy avatar appleguy commented on May 30, 2024

Jercik, thanks for reporting this! I'm surprised this is happening on the layerBacked nodeβ€”I'd actually expect it to occur on the view-backed one, since when the views are removed from the hierarchy they will automatically clear their contents to save memory. This is not always the behavior you want, and so I'm actively thinking about the right API to expose this.

There is an AsyncDisplayKit call that will cause nodes to ignore UIView notifications (such as didMoveToWindow:nil, when being removed from the hierarchy, so it doesn't clear the contents). However you shouldn't be expected to do this in a bunch of places, so we need to fix this in another way.

If you can provide a sample project, that would be especially convenient. We are planning to launch the framework quite soon and I'd love to look at this tonight, tomorrow or over the weekend.

Thanks again, and feel free to ask us any other questions!

from asyncdisplaykit.

Jercik avatar Jercik commented on May 30, 2024

Thank you for quick response!

Here is example project: https://github.com/Jercik/asflickering

On layer-backed nodes, flickering is more visible and occurs more than once, but also on view backed nodes one additional redrawing and flicker is visible after dismissing presented view controller. It would be great, if there was some way to avoid this behavior.

from asyncdisplaykit.

appleguy avatar appleguy commented on May 30, 2024

I have a diff that should resolve this and will try to land it tomorrow once I can get it reviewed by a team member and we can test it properly. Here's the raw diff if you're compelled to poke around with it, but this should be closed out within 24hrs!

http://pastebin.com/8Ay3tWxT

from asyncdisplaykit.

secretiverhyme avatar secretiverhyme commented on May 30, 2024

f7d91bb fixes this.

from asyncdisplaykit.

appleguy avatar appleguy commented on May 30, 2024

Indeed, fixed (verified with your test case @Jercik β€” very helpful, thank you!)

from asyncdisplaykit.

Cabus avatar Cabus commented on May 30, 2024

I'm seeing this effect with version 1.9. Especially during push and pop in a UINavigationController.
However, it happens regardless of 'layerBacked'.
I tried setting 'displaySuspended'. (true in 'didExitHierarchy'. false in 'willEnterHierarchy') but that didn't help. My node consists of an ASImageNode and 2 ASTextNodes. Any further solutions for this?

from asyncdisplaykit.

CodeEagle avatar CodeEagle commented on May 30, 2024

still get blink when pop back

from asyncdisplaykit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.