Rename "sizeToFit:" to "sizeThatFits:" about asyncdisplaykit HOT 4 CLOSED

There's also a typo in the property name:
--- constrainedSizeForCalulatedSize (ASDisplayNode.h)
+++ constrainedSizeForCalculatedSize.

from asyncdisplaykit.

Unfortunately this method is not like either of the others so we should probably rename it entirely. It has intentional side effects: it caches the calculatedSize and importantly sets the constrainedSize, so it was quite intentional to choose the method name that implies side effects (it is the closer of the two).

Thank you for the valuable feedback as I agree we should change the name!

Sent from my iPhone

On Aug 14, 2014, at 1:54 PM, Pyry Jahkola [email protected] wrote:

There's also a typo in the property name:
--- constrainedSizeForCalulatedSize (ASDisplayNode.h)
+++ constrainedSizeForCalculatedSize.

—
Reply to this email directly or view it on GitHub.

from asyncdisplaykit.

Thanks for the report, @pyrtsa! We're considering renaming -sizeToFit: to something more along the lines of -prepareLayoutWithConstrainedSize: — verbose, but also impossible to conflate with the UIKit method. (cc @acoomans)

from asyncdisplaykit.

Yes, that's a TODO I added when rewriting ASDisplayNode's header doc.
BTW there might be a few others TODOs we might want to have a look at before releasing.

from asyncdisplaykit.