Comments (8)
@passy Is there a list of those, that you are ok with?
I mean there are lint errors like:
view.setForeground(null);
that are safe-guarded with an API check before accessing them, although Lint does not understand it. One solution could be to reverse the API check and run that method only then, that would satisfy the Lint I suppose.
from litho.
@pavlospt That sounds pretty reasonable.
We don't have a list right now. I think it might be best to tackle these in a few individual PRs. There may be some that are a bit more invasive and require some thought but a bunch of them are probably just missing annotations or places where we could use @SuppressLint
if it's clear that Lint is overly sensitive.
from litho.
@passy Ok I understand what you mean. Will try to create a PR covering most of them so that we can discuss what is acceptable and should be suppressed and what not :)
from litho.
@pavlospt Awesome!
from litho.
If this one is still relevant I think I can prepare the PR I said some time ago 😂
from litho.
Oh yeah, that would be awesome. Would love to get rid of some more lint warnings. :)
from litho.
A nice alternative to this would be using a Lint baseline file and fix issues in parallel!
from litho.
Hey @pavlospt ! Were there any progress about that? I think we may enable Lint baseline for this config and switch abortOnError
on again
from litho.
Related Issues (20)
- visibleHandler and invisibleHandler is not effective HOT 1
- Relocate Litho dependencies in a location other than JCenter. HOT 1
- Paint Flags support HOT 1
- ClickEvent beyond recycler HOT 4
- TextInput with RTL makes ViewPager jump between pages HOT 1
- Elements outside the viewport are not drawn on entering HOT 2
- Litho HOT 1
- Automirrored vector drawables do not get mirrored when layout is RTL HOT 2
- HorizontalScroll should provide the ability to fade edges HOT 3
- how do you update state from a Android Fragment/View parent? like React's useImperativeHandle
- Are there any plans to replace unsupported APIs (KEYCODE_BACK and #onBackPressed) to support Android's new Predictive back gesture?
- OnUpdateState not invoke on parent recycler component
- How to update prop value of MountSpec from LayoutSpec
- How does Litho (Kotlin API) compare to Compose? HOT 1
- Lazy list not working in project getting error HOT 4
- ContentAllocator API not working HOT 14
- NullPointerException in TextDrawable.Draw, seemingly from a race condition in ComponentHost$InterleavedDispatchDraw
- Setting a background to a container using Style.background(dynamicValue: DynamicDrawable) draws outside of bounds of parent. HOT 1
- Dimension error when adding flexure process
- Unable to import Litho KComponent, ComponentScope and other Litho classes HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from litho.