Comments (15)
@trueadm Quick tests
- Facebook : no
- Quip : no
- Gmail : yes
- Google Docs : doesn't actually show my cursor indicator
from lexical.
I think the simplest and probably most logical solution here is to come up with a LinkBreakNode
that extends TextNode
. Its value would be \n
so text content continues to work properly, with the exception of having a custom createDOM
that renders a br
element. Thoughts on that @yangshun?
from lexical.
@yangshun its not really full plain text. It still has custom emojis, mentions, text delights, hashtags etc
from lexical.
Thanks for reporting this :)
our if curiosity, does this happen on FB with Draft? Also does it happen on other editors like Gmail or Quip?
I wonder if this is an OS bug (maybe it works better with Edge?).
from lexical.
@trueadm I use the text cursor indicator all the time and I have never noticed this before. It's really obvious when it happens because you aren't sure where your typing will happen. But I will check in a few other places and see if I can make it happen.
from lexical.
So I just tried on the Outline Playground on Github (the one you run locally) on my personal Windows machine. The text cursor seems to appear and work correctly. I'll see if I can get my Windows laptop working and see if it's maybe related to the CSS on the Outline Playground on intern.
from lexical.
I'll see if I can get my Windows laptop working and see if it's maybe related to the CSS on the Outline Playground on intern.
I use Windows as a work laptop and can't repro this issue on the Outline Playground on intern.
Outline.Playground.-.Google.Chrome.2021-03-05.08-45-27.mp4
P.S. The indicator isn't captured in the video but it matches the cursor position.
from lexical.
I can repro in plain text mode, but this doesn't happen in rich text mode. I also have to be at the end of the text (cursor at the end) for it to happen to.
from lexical.
Right, I can reproduce in plain text mode too.
from lexical.
My hunch is that this is because we use \n
character rather than <br>
.
from lexical.
Sounds reasonable but I wouldn't say I know enough about Outline to be sure. I'm not exactly sure why we need Outline for plaintext mode though. Wouldn't a <textarea>
do the same?
from lexical.
Thanks that's helpful :)
from lexical.
Fixed in #160.
from lexical.
@trueadm I found another example of this while testing emojii. Is this separate? should I open a separate issue for it?
cursor.indicator.misalignment.mp4
from lexical.
@a11yHolli Yeah it looks related. A fix for that has gone up, it should be live in the next few hours. Let's see if that fixes this problem.
from lexical.
Related Issues (20)
- Bug: CJK composition broken in android firefox
- Bug: ForwardRef Build Issue HOT 4
- Bug: Link node at the end of paragraph is persisted when replacing the entire paragraph after it has been selected via triple-click
- dir is not computed correctly when paragraph starts with a link
- Bug: after undo, input anything will be wrong
- Feature: Document the withKlass option for node replacement
- Feature: Expose <ContentEditable /> HTMLElement ref HOT 6
- Bug: Cut from a table doesn't remove values
- Feature: Document RootNode semantics/special cases
- Feature: Ordered lists starting with upper roman/ lower roman numbers HOT 1
- Bug: $selectAll do not set the selection `style` parameter from the anchored text node
- Bug: history should work with custom TextNodes containing non-standard properties HOT 1
- Allow table update on attribute changes in case of extending (overriding) TableNode
- Bug: build failure on astro integration test due to node version
- Bug: Copy/pasting an image from Slack to Lexical does not work HOT 1
- Bug: Wrong new line (\n) in some cases with the option shouldPreverseNewLines = true HOT 5
- Feature: Deprecate Lexical HOT 2
- Bug: Text mode is not respected when patching text style
- Bug: AutoLink crashes the editor HOT 1
- Bug: "shouldPreserveNewLines" erroneously merges the second node with the above node on conversion back from markdown HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lexical.