Relay + graphql literals about flow HOT 11 CLOSED

The option relay_integration.esmodules has been added, and will be in a future version of Flow (it will be in the changelog once it's in). Once you have it, try it out and confirm if it works for you.

from flow.

It's hard to guess what's going on here. Can you give me an isolated repro?

from flow.

Sure, it’ll be the next day or so. Sorry I was hoping this was a known issue. Ill make a repro with an example.

from flow.

I think I can guess what's going on. Flow's relay integration is not designed with eagerEsModules: true in mind, so you might need to disable this flag. This flag is not enabled internally, so we don't notice it.

@gkz who worked on the integration. To fix it, I think we just need to add another flag similar to this relay flag, and do an additional transform on the module type.

from flow.

That would make a lot of sense, sadly disabling the flag on our end makes swapping over to viteJS (from webpack) a lot harder, we haven't actually managed it, so we were hoping to go all in on ESM and this is the remaining blocker.

Do you still need a repro case? Or is this likely to get resolved? If it isn't no worries I understand the focus on FB's internals needs, but it would be good to know so we can double our efforts to either get commonjs working on vite.

from flow.

Where did you learn about the relay integration options? As far as I am aware, they are not documented or announced.

from flow.

Can't really recall, I think we initially saw them in this issue facebook/relay#3717 then read the code and release notes, we've been running them for quite a long time, its very very helpful. I recon we've had them on for 2+ years now or coming up to that, so my memory is a little fuzzy.

from flow.

Interesting, wasn't aware that anyone in the public was using these options.
Will take a brief look to see if this is easy to add.

from flow.

Thank you, I would offer to help, but as much as I can read ocaml, you really dont want any ocaml we write :)

This feature is one of the main reasons we've stuck with flow over typescript, so so useful, so thank you for adding it!

from flow.

Thank you! We have a few version bumps to get though (LTI) , but will try it out as soon as we can

from flow.

If you're having trouble with rolling out LTI you can post in our Discord https://discord.gg/YpwbdyqQ

from flow.