HandlerCallback exception() runs outside EventBase about fbthrift HOT 5 CLOSED

@varunsharmagit you may have to do something along the lines of

callback->getEventBase() -> runInEventBaseThread ([](){ /* your code */ });

type of thing. I successfully dispatch execption() but that's how you can dispatach callbacks from differen threads that need the eventloop.

at least from reading the source that's what I can tell.

in fact reading the source, that's exactly what the lib does for example

  void exceptionInThread(folly::exception_wrapper ew) {
    getEventBase()->runInEventBaseThread([=](){
        this->exception(ew);
        delete this;
      });

from fbthrift.

Yeah, we figured this out eventually. The following worked:

callback.release()->exceptionInThread(ex);

The release() is needed since the exceptionInThread deletes the original callback which is otherwise held inside a unique_ptr.

from fbthrift.

@varunsharmagit cool, good to know!

from fbthrift.

Yep, you guys got it. result() was refactored at some point to automatically call runInEventBaseThread, but maybe exception() still doesn't.

from fbthrift.

Fixed internally, will be available on github at the next push.

from fbthrift.