0.8.0 break some project about fbjs HOT 6 CLOSED

Is the fbjs in there 0.8.0-alpha.2 or 0.8.0? Not much should have changed between.

from fbjs.

It's the alpha.2, I renamed the issue.
It's the version used by draft-js https://github.com/facebook/draft-js/blob/master/package.json#L32 and [email protected] https://github.com/facebook/react/blob/master/package.json#L38

I don't have the same issue by upgrading react and react-dom to this version on my project (and without draft-js). Maybe it's because react(-dom) don't use fbjs/lib/UserAgent ?

from fbjs.

Hum, I also tried with [email protected] and still have the same issue using draft-js

from fbjs.

Ah, I think this is a polyfill related issue. query.startsWith(name) is expecting String.prototype.startsWith to exist. This is a new method in ES6 (MDN). Especially in Phantom, even new Phantom, you're going to need to include a polyfill for some of these things. The same holds true in real browser environments.

See the note in the docs: https://facebook.github.io/draft-js/docs/advanced-topics-issues-and-pitfalls.html#polyfills In the future we might compile that away and ship with a polyfill (or inline method) ourselves but for the time being, we're going to just depend on the method existing.

Let me know if that doesn't work and we can reopen and reinvestigate.

from fbjs.

PS, thanks for the awesomely detailed report including a repro and (what you could get of a) stack trace.

from fbjs.

Oh, ok I understand !
I fix the issue by adding babel-polyfill to the karma.conf.js file.

Thank you for your help and yours quicks answers !

from fbjs.