Comments (3)
JiamingFB
commented on April 28, 2024
Hi Kilink,
We use different Gson instance for each class because the Gson parsing settings might be different for different classes. Although it is not happening right now, we want to keep the flexibility for the future.
If you've got performance hit because of this, please let us know so that we can try to find a solution.
from facebook-java-business-sdk.
kilink
commented on April 28, 2024
It confers other benefits apart from performance. Currently I can't customize the Gson instance whatsoever (e.g., to turn on pretty printing).
The Gson instance could still be moved to APIContext, and when the need for a customized instance for a specific type arises, then you could handle it either using the current approach in that specific place, or via a factory method on the context (maybe by exposing the GsonBuilder?).
As I mentioned in another issue, I will open a PR for this if you guys agree that it's a good idea.
from facebook-java-business-sdk.
kilink
commented on April 28, 2024
Additionally, I think any class/type-specific behavior can be achieved with type adapters or custom serializers/deserializers, while still maintaining the single Gson instance.
from facebook-java-business-sdk.
Related Issues (20)
- I can't get ad_id,ad_name,adset_id,adset_name's data in AdReportRun.APIRequestGetInsights. HOT 1
- Create Leads via APIs
- create AdCreatives erros
- i can not down this sdk HOT 4
- I only have accesstoken and appid appsecert how to obtain user information HOT 3
- Getting "Two factor authentication required" when generating an admin user system access token. HOT 1
- Two factor authentication required. User have to enter a code from SMS or TOTP code generator to pass 2fac. HOT 4
- adSet/reach-estimate does not exist in SDK HOT 1
- AdsInsights gives json parse error when fetching breakdown link_url_asset HOT 5
- Application does not have permission for this action, Please retry this action in a few minutes
- Futures.addCallback is deprecated HOT 3
- Create adset failed
- Create adset failed
- Add `depends_on` support for Batch Request HOT 1
- Async Insights - Exception while parsing image_asset field HOT 3
- lead fetch fail
- Missing `targeting_automation` field in Targeting HOT 2
- AdCreative with `asset_feed_spec` is not creating the Ad with Website destination HOT 1
- not compatible with latest guava HOT 1
- Why the `VALUE_MAXIMUM ` has been replaced with `VALUE_LIFETIME` in AdsInsights.EnumDatePreset in v19.0.1? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from facebook-java-business-sdk.