Code Monkey home page Code Monkey logo

Comments (6)

sargunv avatar sargunv commented on August 16, 2024

According to https://stackoverflow.com/posts/12447162/revisions, a class loaded by two different class loaders will have two different Class<T> instances. Since Class doesn't implement equals and hashCode, it's not a suitable key for a map when multiple class loaders are involved,

Interestingly enough, this only happens when I use the generated IntelliJ runs, not ./gradlew runClient.

from fabric-loader.

asiekierka avatar asiekierka commented on August 16, 2024

Nice catch! I'm aware of most of the repercussions of multiple classloaders, but couldn't quite identify where things went wrong.

This was already on its way to be fixed in 0.4.0, but with the analysis one could probably get this fixed in 0.3.x...

from fabric-loader.

sargunv avatar sargunv commented on August 16, 2024

This was already on its way to be fixed in 0.4.0, but with the analysis one could probably get this fixed in 0.3.x...

Is 0.4.0 just around the corner? If not, I could make the PR to fix in 0.3.x this weekend if you like.

from fabric-loader.

sargunv avatar sargunv commented on August 16, 2024

This issue should be reopened since my fix was bad.

from fabric-loader.

asiekierka avatar asiekierka commented on August 16, 2024

I'm not giving it another shot at a fix in 0.3.x. It's fixed properly in 0.4.x, backporting the proper fix is way too much effort.

from fabric-loader.

sargunv avatar sargunv commented on August 16, 2024

I just meant leave the issue open until 0.4.x release, as an indicator it's a known issue.

from fabric-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.