Custom CSS property is accessible in the editor but not when compiling about fable-react HOT 6 CLOSED

Using | [<Erased>] Custom of string * obj should work and may solve the problem (I added that behavior afterwards). I'll check...

from fable-react.

I have pushed 3.1.3

There's no 3.1.3 on NuGet, but I added the Fable.Helpers.React.fs file as a Paket GitHub dependency and it works fine 👍

from fable-react.

@inosik This return an SVGAttr because this is the Custom attribute of SVGAttr

Each Attr type have is own Custom case.

IMO we should remove the compiler directive and only provide the static member inline Custom

from fable-react.

Shame on me 😄

This is the right code:

from fable-react.

IMO we should remove the compiler directive and only provide the static member inline Custom

We have to keep the union case for SSR, but it shouldn't be accessible. Unfortunately, you can't make a union case private in F#.

We could do something like this:

// FS0044: This construct is deprecated.
#nowarn "44"
type CSSProp =
    | [<Obsolete("Use the custom-method instead.")>]
      Custom of string * obj

    static member custom (key : string, value : obj) : CSSProp =
#if FABLE_COMPILER
        !!(key, value)
#else
        Custom (key, value)
#endif
#warn "44"

Ideally we would make it a compiler error with [<Obsolete("...", true)>], but then we can't use it inside of the custom-method.

from fable-react.

I have pushed 3.1.3, can you please try and reopen if it's still failing? Thanks!

from fable-react.