Comments (4)
This is probably related to the fact that I'm using fable-splitter withallFiles: true
.
I believe it tries to compile all files in Fable.React to my output folder.
Should the Fable.Helper.ReactServer.fs be wrapped with a #if !Fable
directive @alfonsogarciacaro?
from fable-react.
Yes, that should be the easiest solution, would you mind to PR it? I'm concerned we're having many #if
directives in the code. Probably it would be better to do like Thoth.Json does and keep two different projects for each platform. But for that we would need a comprehensive test suite to make sure the API is consistent.
from fable-react.
Happy to do PR. Maybe there is an other solution, is fable using the fsproj file inside the .fable
folder?
I'm trying to disable to compile tag with
<Compile Include="Fable.Helpers.ReactServer.fs" Condition="$(FABLE_COMPILER) == 'false'" />
.
This doesn't work but I'm not sure that fable looks at the proj file?
Also not sure if what variables are available in msbuild.
from fable-react.
Fable does indeed look at the project file (this is necessary to get the file order) but for .fsproj coming from Nuget packages, it just does a very simplistic resolution that doesn't check conditional. But anyways #124 should solve the problem, thank you!
from fable-react.
Related Issues (20)
- React Server Components integration HOT 2
- Can't figure out how to wrap my view with a Higher Order Component HOT 4
- JsInterop helper for wrapping a higher order component HOT 2
- Can't reference React in Fable HOT 2
- Fable.ReactServer.cssProp very slow HOT 4
- Add Custom DU to DOMAttr HOT 1
- FunctionComponent.Lazy and SSR HOT 1
- Update samples to Fable 3
- ReactDOM.hydrate is no longer supported in React 18 HOT 17
- Can't update shared state passed with useContext? HOT 3
- Q: Use ReactElement import member for Storybook HOT 3
- Missing 'open' from Fable.React.Props? HOT 2
- Last Fable.React upgrade breaks my code HOT 7
- Publish source files from Fable.React.Types and Fable.ReactDom.Types to nuget HOT 5
- Fable.React version 8 depends on React.Dom gte 18 lt 19 according to femto
- Add Pointer Events HOT 3
- Why is useCallback not implemented? HOT 3
- How to obtain a component ref in a function component? HOT 5
- FunctionComponent.Of functions cache breaks reusable code HOT 1
- voidEl breaks with: $ELEMENT is a void element tag and must neither have `children` nor use `dangerouslySetInnerHTML`. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fable-react.