Code Monkey home page Code Monkey logo

Comments (4)

alfonsogarciacaro avatar alfonsogarciacaro commented on July 19, 2024

Hmm, the problem here is that F# doesn't have ad-hoc polymorphism. Sometimes it's possible to emulate it using inline functions and SRTP, but here you need access both to the member and the constructor so the syntax can become very cumbersome (not sure if it's even possible).

If you don't mind using interfaces, you can achieve a similar effect with flexible types:

type IAddClass<'T> =
    abstract AddClass: string -> 'T

type DivComponentProps =
    { value: string; ClassName: string }
    interface IAddClass<DivComponentProps> with
        member this.AddClass c = { this with ClassName = this.ClassName + " " + c }

type SpanComponentProps =
    { text: string; ClassName: string }
    interface IAddClass<SpanComponentProps> with
        member this.AddClass c = { this with ClassName = this.ClassName + " " + c }

let enhance comp (props: #IAddClass<'props>) =
    React.ofFunction comp (props.AddClass "red")

let SpanComponent (props: SpanComponentProps) =
    React.span [
        ClassName props.ClassName
    ] [ React.str props.text ]

let DivComponent (props: DivComponentProps) =
    React.div [
        ClassName props.ClassName
    ] [ React.str props.value ]

let EnhancedDiv = enhance DivComponent
let EnhancedSpan = enhance SpanComponent

from fable-react.

Voronar avatar Voronar commented on July 19, 2024

That is to say what I can't make generic implementation of this code piece:

member this.AddClass c = { this with ClassName = this.ClassName + " " + c }

and I must duplicate the implementation for all types, that implements interface IAddClass?

from fable-react.

alfonsogarciacaro avatar alfonsogarciacaro commented on July 19, 2024

Hmm, not that I can think of. Maybe there is a way using something like FSharpPlus but I'm not sure. AFAIK there's no way to make record constructors generic. If you prefer not to use interfaces, I think the common way is to pass the transform in a parameter (as with a functor):

type DivComponentProps =
    { value: string; ClassName: string }

type SpanComponentProps =
    { text: string; ClassName: string }

let enhance comp (addClass: 'props->string->'props) (props: 'props) =
    React.ofFunction comp (addClass props "red")

let SpanComponent (props: SpanComponentProps) =
    React.span [
        ClassName props.ClassName
    ] [ React.str props.text ]

let DivComponent (props: DivComponentProps) =
    React.div [
        ClassName props.ClassName
    ] [ React.str props.value ]

let EnhancedDiv = enhance DivComponent (fun p c ->
    { p with ClassName = p.ClassName + " " + c })

let EnhancedSpan = enhance SpanComponent (fun p c ->
    { p with ClassName = p.ClassName + " " + c })

from fable-react.

Voronar avatar Voronar commented on July 19, 2024

According to this declined (by @dsyme) suggestion and my speculations about the subject I think a truly React HOC via record props is impossible even in a future.

from fable-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.