Comments (4)
Hmm, the problem here is that F# doesn't have ad-hoc polymorphism. Sometimes it's possible to emulate it using inline functions and SRTP, but here you need access both to the member and the constructor so the syntax can become very cumbersome (not sure if it's even possible).
If you don't mind using interfaces, you can achieve a similar effect with flexible types:
type IAddClass<'T> =
abstract AddClass: string -> 'T
type DivComponentProps =
{ value: string; ClassName: string }
interface IAddClass<DivComponentProps> with
member this.AddClass c = { this with ClassName = this.ClassName + " " + c }
type SpanComponentProps =
{ text: string; ClassName: string }
interface IAddClass<SpanComponentProps> with
member this.AddClass c = { this with ClassName = this.ClassName + " " + c }
let enhance comp (props: #IAddClass<'props>) =
React.ofFunction comp (props.AddClass "red")
let SpanComponent (props: SpanComponentProps) =
React.span [
ClassName props.ClassName
] [ React.str props.text ]
let DivComponent (props: DivComponentProps) =
React.div [
ClassName props.ClassName
] [ React.str props.value ]
let EnhancedDiv = enhance DivComponent
let EnhancedSpan = enhance SpanComponent
from fable-react.
That is to say what I can't make generic implementation of this code piece:
member this.AddClass c = { this with ClassName = this.ClassName + " " + c }
and I must duplicate the implementation for all types, that implements interface IAddClass
?
from fable-react.
Hmm, not that I can think of. Maybe there is a way using something like FSharpPlus but I'm not sure. AFAIK there's no way to make record constructors generic. If you prefer not to use interfaces, I think the common way is to pass the transform in a parameter (as with a functor):
type DivComponentProps =
{ value: string; ClassName: string }
type SpanComponentProps =
{ text: string; ClassName: string }
let enhance comp (addClass: 'props->string->'props) (props: 'props) =
React.ofFunction comp (addClass props "red")
let SpanComponent (props: SpanComponentProps) =
React.span [
ClassName props.ClassName
] [ React.str props.text ]
let DivComponent (props: DivComponentProps) =
React.div [
ClassName props.ClassName
] [ React.str props.value ]
let EnhancedDiv = enhance DivComponent (fun p c ->
{ p with ClassName = p.ClassName + " " + c })
let EnhancedSpan = enhance SpanComponent (fun p c ->
{ p with ClassName = p.ClassName + " " + c })
from fable-react.
According to this declined (by @dsyme) suggestion and my speculations about the subject I think a truly React HOC via record props is impossible even in a future.
from fable-react.
Related Issues (20)
- How to instantiate a custom React Component in Fable? HOT 2
- module.hot.addStatusHandler is not a function HOT 8
- React Server Components integration HOT 2
- Can't figure out how to wrap my view with a Higher Order Component HOT 4
- JsInterop helper for wrapping a higher order component HOT 2
- Can't reference React in Fable HOT 2
- Fable.ReactServer.cssProp very slow HOT 4
- Add Custom DU to DOMAttr HOT 1
- FunctionComponent.Lazy and SSR HOT 1
- Update samples to Fable 3
- ReactDOM.hydrate is no longer supported in React 18 HOT 17
- Can't update shared state passed with useContext? HOT 3
- Q: Use ReactElement import member for Storybook HOT 3
- Missing 'open' from Fable.React.Props? HOT 2
- Last Fable.React upgrade breaks my code HOT 7
- Publish source files from Fable.React.Types and Fable.ReactDom.Types to nuget HOT 5
- Fable.React version 8 depends on React.Dom gte 18 lt 19 according to femto
- Add Pointer Events HOT 3
- Why is useCallback not implemented? HOT 3
- How to obtain a component ref in a function component? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fable-react.