`set_maintenance_mode` should use atomic write. about django-maintenance-mode HOT 8 CLOSED

@reitermarkus thank you for reporting this issue.

from django-maintenance-mode.

Depends on fabiocaccamo/python-fsutil#91

from django-maintenance-mode.

@reitermarkus fixed in 0.21.0 version.

from django-maintenance-mode.

Thanks! Although I would remove

fabiocaccamo/python-fsutil@6c8a58b#diff-d82a200cf6742866f0d549f5bd4a22416ef6cdbcc1cde15c6b32c64f2663fe70R1330

since this can again have the same race condition and pollute user directories with temporary files.

from django-maintenance-mode.

@reitermarkus for the temp file directory I used the same file directory to ensure that the temporary file is created on the same filesystem of the final file and guarantee atomicity of the replace operation, otherwise there is a potential risk of data corruption or loss.

What do you think is best to do here?

from django-maintenance-mode.

Given that the state can only be 0/1, maybe change to simply checking the existence instead of the contents of the file.

from django-maintenance-mode.

The local file backend uses the same logic as the other backends.

from django-maintenance-mode.

@reitermarkus check fabiocaccamo/python-fsutil@11fbc5e

from django-maintenance-mode.