Comments (6)
It would push the mimimum Ansible requirement to 1.5, but I think that's acceptable... I'll look into actual release dates a bit closer.
I do feel that accepting the hostkey without verification is on the dangerous side for a deploy role, as it opens the door to man-in-the-middle attacks that you would never know about. Not adding this option at lease forces the consumers to use some other avenue to add the github (or any VCS source server) hostkey.
from ansible-project_deploy.
Allright. I was expecting something like this. Then we will have to add the hostkey by hand.
Ping me if you changed your mind. I'll prepare a PR then.
from ansible-project_deploy.
I've used this in the past (also the same security risk, but because the 'lookup' plugin runs on the host machine, the MIM would have to target both my current location and the server I'm deploying to at the same time).
https://coderwall.com/p/wi8yrq/ansible-lineinfile-with-lookup
from ansible-project_deploy.
Thanks!
from ansible-project_deploy.
Decided agains adding the accept_hostkey
option, because it makes 'doing it wrong' too easy.
from ansible-project_deploy.
@rommsen I use the bfmartin.ssh_known_hosts role to allow github.com access:
roles:
- { role: bfmartin.ssh_known_hosts, host: github.com }
from ansible-project_deploy.
Related Issues (11)
- Copy vendor dir to speed up composer install HOT 3
- Rollback functionality HOT 9
- Ansible warnings in 2.3.0 HOT 1
- Protect deploy state=cleanup against failed deploys HOT 2
- Ansible warnings HOT 1
- ansible galaxy page not found HOT 1
- /shared/system is a "system_path"? HOT 3
- deploy module should not re-create the new_release_path fact on cleanup HOT 1
- post_tasks doesn't like sudo: yes HOT 4
- Move to package manager's modules? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ansible-project_deploy.