Code Monkey home page Code Monkey logo

Comments (6)

ramondelafuente avatar ramondelafuente commented on September 26, 2024

It would push the mimimum Ansible requirement to 1.5, but I think that's acceptable... I'll look into actual release dates a bit closer.

I do feel that accepting the hostkey without verification is on the dangerous side for a deploy role, as it opens the door to man-in-the-middle attacks that you would never know about. Not adding this option at lease forces the consumers to use some other avenue to add the github (or any VCS source server) hostkey.

from ansible-project_deploy.

rommsen avatar rommsen commented on September 26, 2024

Allright. I was expecting something like this. Then we will have to add the hostkey by hand.

Ping me if you changed your mind. I'll prepare a PR then.

from ansible-project_deploy.

ramondelafuente avatar ramondelafuente commented on September 26, 2024

I've used this in the past (also the same security risk, but because the 'lookup' plugin runs on the host machine, the MIM would have to target both my current location and the server I'm deploying to at the same time).

https://coderwall.com/p/wi8yrq/ansible-lineinfile-with-lookup

from ansible-project_deploy.

rommsen avatar rommsen commented on September 26, 2024

Thanks!

from ansible-project_deploy.

ramondelafuente avatar ramondelafuente commented on September 26, 2024

Decided agains adding the accept_hostkey option, because it makes 'doing it wrong' too easy.

from ansible-project_deploy.

William-Yeh avatar William-Yeh commented on September 26, 2024

@rommsen I use the bfmartin.ssh_known_hosts role to allow github.com access:

roles:
    - { role: bfmartin.ssh_known_hosts, host: github.com }

from ansible-project_deploy.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.