Code Monkey home page Code Monkey logo

Comments (8)

Plopix avatar Plopix commented on May 28, 2024 1

@yhanini can you do a PR, also I would like more

To me xdebug can reduce performances, then I would love to be able to enable/disable it very easily. (using the provisionning/engine/php.ini + ez up
=> today in your code installation is triggered by the env var but installation could be in the image actually

XDEBUG_REMOTE_AUTOSTART and XDEBUG_REMOTE_CONNECT_BACK could be hardcode right? not sure if we should let then in the docker-compose file. same with XDEBUG_REMOTE_HOST is that the "host" then I think that could be automated.

=> actually I think all those value should be put in the php.ini we don't even need a script
Those are just xdebug properties

  • action 2: add the correct configuration (commented out) in thephp.ini

To sum up:

At then end we should have the xdebug properties all setup in the provisionning/engine/php.ini (with xdebug disabled by default)

And to enable it, the procedure should be to just enable it in this provisionning/engine/php.ini and run ez up.

=> that is it!

from launchpad.

kemoc avatar kemoc commented on May 28, 2024

I ask to add more settings configurable by ENVs, my example xdebug settings without docker:

[xdebug]
xdebug.max_nesting_level = 500
xdebug.remote_autostart = 0
xdebug.remote_enable = 1
xdebug.remote_host = localhost
xdebug.remote_port = 9000
xdebug.idekey = "PHPStorm"
xdebug.profiler_enable_trigger = 1
; default cachegrind.out.%p
xdebug.profiler_output_name = cachegrind.out.%s
xdebug.profiler_output_dir = "/tmp/xdebug/profiler/output"
xdebug.trace_output_dir = "/tmp/xdebug/trace/output"
xdebug.remote_cookie_expire_time = 7200

so for me important are enable/disable Xdebug by Cookie or GET, for it will be needed in container
XDEBUG_IDEKEY
XDEBUG_REMOTE_ENABLE
and xdebug.max_nesting_level should be configurable too, so
XDEBUG_MAX_NESTING_LEVEL

from launchpad.

kemoc avatar kemoc commented on May 28, 2024

@Plopix

XDEBUG_REMOTE_AUTOSTART and XDEBUG_REMOTE_CONNECT_BACK could be hardcode right?

I did not understand what you mean hardcoded but for me XDEBUG_REMOTE_AUTOSTART must able to set value by .env and/or docker-compose.yml

from launchpad.

yhanini avatar yhanini commented on May 28, 2024

PR : #43

from launchpad.

Plopix avatar Plopix commented on May 28, 2024

857d991

from launchpad.

Plopix avatar Plopix commented on May 28, 2024

enjoy ! #44

Don't forget to get the last engine: docker pull plopix/docker-php-ez-engine:7.2

from launchpad.

Plopix avatar Plopix commented on May 28, 2024

@kemoc you can now do all the config that you want through the php.ini

from launchpad.

SalvatorePollaci avatar SalvatorePollaci commented on May 28, 2024

Thank you. Great work!

from launchpad.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.