spacy/attrs.pxd missing about spacy HOT 6 CLOSED

(Oh, and best of luck for the project!)

from spacy.

Hey

Argh, thanks. I'm using Travis, but I'm testing installation via pip. The attrs.pxd file ends up in the sdist, because it's in the package data.

I need to CI both installation from git clone and installation via pip. I'll figure that out.

from spacy.

Yes, always sdist from a fresh clone

from spacy.

You need a CI that tests master, and all pull requests, ideally (although I'm not sure what scale of contribution you expect/intend on this licensing model). It's pretty standard integration on github.

from spacy.

The problem is that the sdist relies on an intermediate state not in the repo --- the Cython-generated .cpp files. I have the CI set up to test the sdist because it's actually not so simple to build the .cpp files in a way that ensures the sdist doesn't depend on some side-effect of the Cythonizing.

Anyway. I'll find a way to fix this and ensure that both the installation from pip and the compilation from master are clean.

from spacy.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from spacy.